39 changed files with 2019 additions and 213 deletions
+2
View File
@@ -69,3 +69,5 @@ python3 scripts/bridge_service.py --config /path/to/private/bridge.json
完成报告先进入私有持久outbox,有界重试并幂等确认;执行完成与集成验收分别记录。通知要求每目标最多一条未处理,其余保留并合并。当前支持execution_notification_targets显式映射:依据正式任务session_id,将任务相关事件和ETA优先交执行者;未映射事项及系统事件交配置的唯一副主控,决策直达总控。目标变更须保留旧回执并对账迁移,不盲重放积压。宿主原生队列总数与取消能力未知时如实说明,不能声称已清空。配置、实现范围与验收要求见[运行接入](references/operations.md#一层副主控的路由与可靠上报)。
重大事件驱动用户汇报,普通进度、短暂重连和自动恢复留在内部日志。故障钩子提供持久去重、分级升级和恢复记录;额外服务需按授权接入。
决策由主控先建卡,提交后进入待检查;接受、落实完成和真实会话归档分别记录。每项真实决策绑定一个独立咨询会话,用有限凭据只维护本决策,实质修订保留旧选择并要求重确认。详情可咨询和查看版本历史;真实会话接通及宿主归档须现场验证,不能用占位记录代替。参见[独立决策会话接入](references/decision-sessions.md)。
+25 -1
View File
@@ -112,7 +112,7 @@ description: 组织项目的多个 AI 会话并行工作,将进度、证据和
需要人类决定的事项集中登记在决策页,以卡片显示问题、影响、优先级和当前状态;点击查看背景、方案取舍、推荐及依据。仅在有实际依据时登记期限,不制造紧迫感。有明确候选方案时提供清晰可点击选项及补充意见;推荐不预选,选择不等于提交,只有明确提交后保存实际选择。
沟通页只给简短提醒并链接具体卡片,不重复堆完整方案或内部载荷。提交使用持久幂等键,事务保存响应并排入总控投递队列;重试不得重复执行或串到另一决策/项目。标记“已提交/待核实/已决定”与运维授权、方案执行和业务验收分开。涉及权限的选择进入待核实,不能仅凭网页令牌或来源字段当成人类授权;由总控通过受支持会话与既定边界核实。
沟通页只给简短提醒并链接具体卡片,不重复堆完整方案或内部载荷。提交使用持久幂等键,事务保存响应并排入总控投递队列;重试不得重复执行或串到另一决策/项目。状态区分待选择、待主控检查、已接受待落实、需重新考虑与完成;用户提交不直接结束决策,与运维授权、方案执行和业务验收分开。涉及权限的选择进入待核实,不能仅凭网页令牌或来源字段当成人类授权;由总控通过受支持会话与既定边界核实。
空状态不放模拟待决定事项。验收使用隔离临时实例,不把合成问题、选项或通知投进用户正式入口。检查详情展开、选项与备注、显式提交、失败保留草稿、已决状态、并发/重试/目标隔离及真实总控队列。
@@ -132,6 +132,10 @@ description: 组织项目的多个 AI 会话并行工作,将进度、证据和
## 可靠完成上报与通知背压
咨询桥接按真实待发或在途消息分配,不因绑定存在就长期占位。空闲释放前核对worker、待交付回执和未知执行;只停止自有桥接,不终止模型writer。保留并发上限,按持久等待时间公平轮转;人类咨询及决策优先,普通事项达到老化窗口后按先到顺序提升,不能永久饥饿。断网时保留原消息、幂等键和回执,恢复后续传;可能已执行的输入先查原会话和关联回复,禁止换ID盲重放。具体调度与恢复见运行指南。
页面按证据区分已保存、排队、宿主送达、真实处理、关联回复和受阻。保存成功不等于送达,模型回复不等于业务验收;未知结果明确待核对。普通成功阶段收起保留可查,等待和受阻短提示,不堆叠技术回执。
执行负责人完成工作后,先把带稳定报告ID、任务版本、证据和检查结果的完成报告保存到私有持久 outbox,再按有界退避重试交付;服务落库回执确认后才标已上报。重试复用同一幂等ID,不重新执行业务操作;结果未知先对账,达到上限保留待核查状态,交副主控处理。对话中的“完成”不能替代可靠落库,执行完成也不等于集成验收完成;集成负责人另核对源产物、接口和验收证据。
通知按目标背压:同一目标最多一条未处理通知,后续事件保留在持久队列并按关联ID合并。排队accepted不等于处理完成,需核对真实目标turn/处理回执才能释放名额;未知结果不得通过换ID或清本地记录绕过。应用outbox、已知inflight与宿主原生队列分别记账;无法读取宿主总数或确认取消时,必须写未知/不支持,不能宣称原生队列已清空。现有机制与限制见运行指南。
@@ -157,3 +161,23 @@ description: 组织项目的多个 AI 会话并行工作,将进度、证据和
任务分支视图以版本交付为主线、独立工作任务为支线,节点只表达实际登记的关键里程碑,不冒充Git提交或提交历史。交付任务显式使用kind=delivery,工作任务使用kind=work及delivery_id归属;没有归属显示未归属,不从version中的提交哈希推测。只有真实集成关系且源、目标均通过集成验收才绘制汇合。
默认显示所有未结束任务及递归必要前置,显示全部开关用于历史。悬停、键盘焦点及触屏选择突出递归上下游关系;无关项淡化但可读,退出交互恢复,不修改任务事实或自动开启全部。字段校验和迁移见references/operations.md,交互与验收见references/design-system.md。
## 决策修订、咨询与收尾
决策只来自真实需求,卡片包含简介及关联任务。用户可选择方案或自由填写意见,至少一项有效;提交保留当时版本与选项快照,进入pending_review。主控核对真实提交的影响和执行计划后接受为accepted或退回needs_reconsideration;接受不等于系统操作授权。内容实质变化保留旧快照并要求按新revision重新确认,旧记录不能静默覆盖。关联新决策显式登记来源,不自动编造。
独立咨询会话的创建、有限凭据交付、桥接与真实归档步骤见 [决策会话接入](references/decision-sessions.md)。
每项决策的独立咨询绑定真实已注册会话,未接通如实显示。咨询agent只获该决策的有限凭据,可读取历史、维护内容、请求主控核实事实;不能提交用户选择、接受、完成、归档、换绑或操作其他任务。凭据仅私有交付,不能交普通面板令牌。角色提示禁止代码、系统操作及执行决策,不声称OS级硬隔离。事实回复不是用户批准。
主控检查后记录结论、交接及证据才完成;完成后由获授权总控调用宿主真实归档工具,再保存回执,服务记录不冒充归档操作。隔离测试不能代替真实会话绑定与往返,尚未验证必须明示;没有真实待决定事项时不得为验收创建生产决策或会话。
已有专门人类入口时,主控、副主控和执行者不得直接向用户提问;问题、待选择、待授权及关键结论定向交唯一入口,由入口理解并与人类交互,再整理给主控,不经过底层事件队列。需选项先建真实决策卡,入口简短链接。决策页内嵌咨询只回答该决策范围问题,不另设一般项目入口;人类决定和审批仍走决策卡与唯一入口。
## 网页草稿持久边界
沟通输入、决策意见与选择、决策咨询输入应在浏览器本地持久保存,按实例、目标会话、决策与内容版本隔离;退出页面、刷新及重新登录后恢复同范围草稿。草稿不是已提交事实,不上传草稿,不将token写入草稿记录。仅收到成功确认后清除对应提交的草稿,或由用户明确清除单项;失败和结果未知保留正文与幂等重试信息,禁止自动重发。内容版本变化保留旧稿供明确重确认,不能静默覆盖新版本或沿用旧选择作为批准。
本地存储不可用时如实提示,不能宣称已保存;本地浏览器数据被清理、设备更换或旧版未持久化的已丢稿不承诺恢复。已有唯一人类入口时,相关限制与所需用户操作仍由该入口沟通。
功能修复不得擅自增加按钮和解释性文案。草稿自动保存、恢复及成功后清除在后台完成,不放常驻存储说明、清除草稿按钮或冗余成功提示;仅真正阻止操作并需要人类处理的错误或版本冲突显示最短必要提示。移除控件不删除已有草稿或改变已提交决定。
+23 -1
View File
@@ -21,6 +21,27 @@ def browser_body(text):
return text[match.end():] if match else text
def delivery_fields(row):
"""Expose evidence-based transport stages without private queue receipts."""
if row.get('source') != 'human' or row.get('origin') != 'coordination':
return {}
status = row.get('status')
submission = row.get('submission') or {}
if isinstance(submission, str):
submission = json.loads(submission)
if status in ('uncertain', 'failed'):
return dict(delivery_stage='blocked', delivery_reason=(
'执行结果待核对,请勿重复发送' if status == 'uncertain' else '处理失败,请查看记录'))
if status == 'completed' and row.get('response_id'):
return dict(delivery_stage='replied')
if submission.get('state') == 'observed':
return dict(delivery_stage='processing')
if submission.get('state') == 'accepted':
return dict(delivery_stage='delivered')
# A local start or submitting record is not proof of host acceptance.
return dict(delivery_stage='queued')
def project(rows, links):
by_id = {row['id']: row for row in rows}
metadata = {link['message_id']: link for link in links}
@@ -101,5 +122,6 @@ def project(rows, links):
if key in seen:
continue
seen.add(key)
result.append({**{k: row.get(k) for k in ('id', 'source', 'status', 'created')}, 'text': text, 'log_id':incident_links.get(group)})
result.append({**{k: row.get(k) for k in ('id', 'source', 'status', 'created', 'reply_to')},
**delivery_fields(row), 'text': text, 'log_id':incident_links.get(group)})
return result
+45 -4
View File
@@ -198,10 +198,23 @@ class Handler(BaseHTTPRequestHandler):
return True
def auth(self):
self.decision_scope = None
supplied = self.headers.get('Authorization', '')
if not hmac.compare_digest(supplied.encode('utf-8'), ('Bearer ' + self.server.token).encode('utf-8')):
if hmac.compare_digest(supplied.encode('utf-8'), ('Bearer ' + self.server.token).encode('utf-8')):
return True
scope = self.server.store.decision_credential_scope(supplied[7:]) if supplied.startswith('Bearer ') else None
if scope is None:
self.output(401, {'error':'authentication required'})
return False
path = urlsplit(self.path).path
base = '/api/decisions/' + scope
allowed = ((self.command=='GET' and path in (base,base+'/history',base+'/consultation'))
or (self.command=='PATCH' and path==base)
or (self.command=='POST' and path==base+'/facts'))
if not allowed or (self.command!='GET' and self.server.store.decision_get(scope)['status']=='completed'):
self.output(403, {'error':'credential scope rejected'})
return False
self.decision_scope = scope
return True
def do_GET(self):
@@ -218,7 +231,18 @@ class Handler(BaseHTTPRequestHandler):
state['primary_session_id'] = self.server.primary_session_id
state['metrics'] = self.server.metrics.snapshot()
state['eta_clock'] = dict(self.server.eta_clock.status)
try:
entry = re.search(r'<script\b[^>]*\bsrc="(/assets/[^"/]+\.js)"', (self.server.web_root/'index.html').read_text(encoding='utf-8'))
state['frontend_entrypoint'] = entry.group(1) if entry else None
except OSError:
state['frontend_entrypoint'] = None
self.output(200, state)
elif parts.path == '/api/decision-bridge-bindings' and not parts.query:
self.output(200,self.server.store.decision_bindings())
elif re.fullmatch(r'/api/decisions/[A-Za-z0-9_.:-]+(?:/(?:history|consultation))?',parts.path) and not parts.query:
segments=parts.path.split('/')
method = {'history':self.server.store.decision_history,'consultation':self.server.store.decision_consultation}.get(segments[-1]) if len(segments)==5 else self.server.store.decision_get
self.output(200,method(segments[3]))
elif parts.path == '/api/queue-health' and not parts.query:
self.output(200,self.server.store.queue_health())
elif parts.path == '/api/task-reports':
@@ -246,6 +270,8 @@ class Handler(BaseHTTPRequestHandler):
self.output(200, {'messages':reader(query['session_id'][0])})
else:
self.output(404, {'error':'not found'})
except Conflict:
self.output(409, {'error':'state conflict'})
except (Invalid,ValueError):
self.output(400, {'error':'invalid request'})
except Exception:
@@ -295,8 +321,13 @@ class Handler(BaseHTTPRequestHandler):
data = json.loads(self.rfile.read(length))
if not isinstance(data, dict):
raise Invalid('object required')
if getattr(self,'decision_scope',None) and self.command=='PATCH':
allowed={'expected_revision','reason','title','summary','question','details','impact','recommendation','options','deadline','priority'}
if data.keys()-allowed:
self.output(403, {'error':'credential content scope rejected'})
return
store = self.server.store
routes = {'/api/task-reports':store.task_report, '/api/attention':store.attention, '/api/eta-notifications/ack':store.eta_ack, '/api/decisions':store.decision, '/api/decision-notifications/ack':store.decision_ack,
routes = {'/api/decision-notifications/submitting':store.decision_submitting, '/api/task-reports':store.task_report, '/api/attention':store.attention, '/api/eta-notifications/ack':store.eta_ack, '/api/decisions':store.decision, '/api/decision-notifications/ack':store.decision_ack,
'/api/hook-notifications/submitting':store.hook_submitting,
'/api/hook-notifications/coalesce':store.hook_coalesce, '/api/hooks':store.hook, '/api/hooks/escalate':store.hook_escalate, '/api/hooks/ack':store.hook_ack,
'/api/sessions':store.session, '/api/session-requests':store.request,
@@ -310,8 +341,18 @@ class Handler(BaseHTTPRequestHandler):
result = store.integrate(self.path.split('/')[3],data)
elif self.command == 'POST' and re.fullmatch(r'/api/eta-reviews/[A-Za-z0-9_.:-]+/complete',self.path):
result = store.eta_complete(self.path.split('/')[3],data)
elif self.command == 'POST' and re.fullmatch(r'/api/decisions/[A-Za-z0-9_.:-]+/respond',self.path):
result = store.decision_respond(self.path.split('/')[3],data)
elif self.command == 'PATCH' and re.fullmatch(r'/api/decisions/[A-Za-z0-9_.:-]+',self.path):
result = store.decision_patch(self.path.split('/')[3],data)
elif self.command == 'POST' and re.fullmatch(r'/api/decisions/[A-Za-z0-9_.:-]+/facts/[A-Za-z0-9_.:-]+/answer',self.path):
segments=self.path.split('/')
result = store.decision_fact_answer(segments[3],segments[5],data)
elif self.command == 'POST' and re.fullmatch(r'/api/decisions/[A-Za-z0-9_.:-]+/(respond|review|complete|archive-receipt|bind-session|consultation|consultation-credential|facts)',self.path):
actions = {'respond':store.decision_respond,'review':store.decision_review,'complete':store.decision_complete,
'archive-receipt':store.decision_archive,'bind-session':store.decision_bind,
'consultation':store.decision_consultation,'consultation-credential':store.decision_credential,'facts':store.decision_fact}
if self.path.endswith('/bind-session') and data.get('session_id')==self.server.primary_session_id:
raise Conflict('primary session cannot be bound')
result = actions[self.path.split('/')[-1]](self.path.split('/')[3],data)
elif self.command == 'POST' and self.path in routes:
result = routes[self.path](data)
else:
+462 -64
View File
@@ -128,6 +128,37 @@ class Store:
source TEXT NOT NULL, data TEXT NOT NULL,
PRIMARY KEY(session_id,external_id,source));
''')
db.executescript("""
CREATE TABLE IF NOT EXISTS decision_history(
seq INTEGER PRIMARY KEY AUTOINCREMENT, decision_id TEXT NOT NULL, data TEXT NOT NULL);
CREATE TABLE IF NOT EXISTS decision_operations(
decision_id TEXT NOT NULL, action TEXT NOT NULL, key TEXT NOT NULL,
request TEXT NOT NULL, result TEXT NOT NULL, PRIMARY KEY(decision_id,action,key));
CREATE TABLE IF NOT EXISTS decision_workflow_notifications(
seq INTEGER PRIMARY KEY AUTOINCREMENT, id TEXT UNIQUE NOT NULL,
decision_id TEXT NOT NULL, event_key TEXT NOT NULL UNIQUE, data TEXT NOT NULL,
delivered_at REAL, cancelled_at REAL, submission_started_at REAL);
CREATE TABLE IF NOT EXISTS decision_credentials(
token_hash TEXT PRIMARY KEY, decision_id TEXT NOT NULL, created REAL NOT NULL);
CREATE TABLE IF NOT EXISTS decision_facts(
id TEXT PRIMARY KEY, decision_id TEXT NOT NULL, data TEXT NOT NULL);
""")
db.execute('BEGIN IMMEDIATE')
if 'workflow' not in {r['name'] for r in db.execute('PRAGMA table_info(decisions)')}:
db.execute('ALTER TABLE decisions ADD COLUMN workflow TEXT')
for row in db.execute('SELECT * FROM decisions WHERE workflow IS NULL').fetchall():
value = self._decision(row)
self._save_decision(db,value)
self._decision_history(db,value,'version',self._decision_content(value))
if value['response']:
self._decision_history(db,value,'submission',value['response'])
self._decision_notice(db,value,'session_required','control','session:'+value['id'])
old_notice = db.execute('SELECT * FROM decision_notifications WHERE decision_id=?',(value['id'],)).fetchone()
if old_notice:
payload = dict(notification_id=old_notice['id'],target='control',decision=value,
event=dict(kind='submitted',revision=1,created=value['response'].get('created')))
db.execute('INSERT OR IGNORE INTO decision_workflow_notifications(id,decision_id,event_key,data,delivered_at) VALUES(?,?,?,?,?)',
(old_notice['id'],value['id'],'legacy:'+value['id'],json.dumps(payload),old_notice['delivered_at']))
db.execute('INSERT OR IGNORE INTO metadata(key,value) VALUES(?,?)',('instance_id',secrets.token_hex(16)))
self.instance_id=db.execute('SELECT value FROM metadata WHERE key=?',('instance_id',)).fetchone()['value']
@@ -184,9 +215,19 @@ class Store:
db.execute('BEGIN IMMEDIATE')
old = db.execute('SELECT data FROM sessions WHERE id=?', (sid,)).fetchone()
old = json.loads(old['data']) if old else {}
if old and old.get('role')!='decision' and record['role']=='decision':
raise Conflict('executor or main session cannot become consultation')
record.update(thread_id=thread or old.get('thread_id', ''),
last_seen=old.get('last_seen'), created=old.get('created', time.time()))
record['thread_url']=thread_url or old.get('thread_url','')
for decision_row in db.execute('SELECT * FROM decisions'):
bound=self._decision(decision_row)
if bound['session_id']==sid:
if (record['role']!='decision' or record['wp']!=bound['id']
or record['thread_id']!=bound['session_thread_id']):
raise Conflict('bound session identity immutable')
elif bound['session_thread_id'] and record['thread_id'].lower()==bound['session_thread_id'].lower():
raise Conflict('bound thread cannot be reused')
self._put(db, 'sessions', record)
self._event(db, 'session.registered', '会话记录已登记', sid)
return record
@@ -301,8 +342,8 @@ class Store:
if not item['required']:
continue
if item.get('decision_id'):
decision = db.execute('SELECT response FROM decisions WHERE id=?',(item['decision_id'],)).fetchone()
if not decision or decision['response'] is not None:
decision = db.execute('SELECT * FROM decisions WHERE id=?',(item['decision_id'],)).fetchone()
if not decision or self._decision(decision)['status'] not in ('open','needs_reconsideration'):
continue
if item.get('task_id'):
task = db.execute('SELECT data FROM tasks WHERE id=?',(item['task_id'],)).fetchone()
@@ -847,11 +888,13 @@ class Store:
@staticmethod
def public_message(row):
from .conversation import delivery_fields
result = {k: row[k] for k in ('id','session_id','text','source','reply_to','status','created','response_id')}
result['outcome'] = row['status'] if row['status'] in ('completed','failed','uncertain') else None
result['origin'] = row['origin']
result['execution'] = 'started' if row['started'] else 'not_started'
result['submission'] = json.loads(row['submission']) if row['submission'] else None
result.update(delivery_fields(dict(row)))
return result
def send(self, data):
@@ -865,6 +908,10 @@ class Store:
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
self._get(db, 'sessions', sid)
for decision_row in db.execute('SELECT * FROM decisions'):
bound=self._decision(decision_row)
if bound['session_id']==sid and bound['status']=='completed':
raise Conflict('consultation closed')
old = db.execute('SELECT * FROM messages WHERE session_id=? AND idempotency_key=?', (sid,key)).fetchone()
if old:
if (old['text'],old['source'],old['reply_to']) != (body,source,reply):
@@ -1471,9 +1518,10 @@ class Store:
eta = stats('eta_reviews','created',eta_pending)
eta['cancelled_count'] = db.execute(
'SELECT count(*) FROM eta_reviews WHERE cancelled_at IS NOT NULL').fetchone()[0]
decisions = stats('decision_notifications',"json_extract(data,'$.response.created')",
'delivered_at IS NULL')
decisions['cancelled_count'] = 0
decisions = stats('decision_workflow_notifications',"json_extract(data,'$.event.created')",
'delivered_at IS NULL AND cancelled_at IS NULL')
decisions['cancelled_count'] = db.execute('SELECT count(*) FROM decision_workflow_notifications WHERE cancelled_at IS NOT NULL').fetchone()[0]
decisions['submission_started_unconfirmed_count'] = db.execute('SELECT count(*) FROM decision_workflow_notifications WHERE submission_started_at IS NOT NULL AND delivered_at IS NULL AND cancelled_at IS NULL').fetchone()[0]
reports = db.execute(
"SELECT count(*) AS received_total, sum(CASE WHEN json_extract(data,'$.created') "
"BETWEEN ? AND ? THEN 1 ELSE 0 END) AS received_last_60s FROM task_reports",(since,now)).fetchone()
@@ -1504,22 +1552,103 @@ class Store:
return {'notification_id':notification_id,'status':'delivered','duplicate':already}
@staticmethod
def _decision(row):
DECISION_FIELDS = {'id','title','question','impact','priority','details','recommendation',
'options','deadline','requires_authorization','task_id','summary','supersedes_id'}
@classmethod
def _decision_content(cls, value):
return {k:value.get(k) for k in cls.DECISION_FIELDS}
@classmethod
def _decision(cls, row):
if 'workflow' in row.keys() and row['workflow']:
return json.loads(row['workflow'])
result = json.loads(row['data'])
result.setdefault('summary','')
result.setdefault('supersedes_id',None)
response = json.loads(row['response']) if row['response'] else None
result['response'] = response
result['status'] = ('pending_verification' if result['requires_authorization'] else 'decided') if response else 'open'
if response:
response = dict(response,revision=1,snapshot=cls._decision_content(result))
result.update(response=response,status='pending_review' if response else 'open',revision=1,
session_id=None,session_thread_id=None,archive_status='none',review=None,
completion=None,related_decision_ids=[])
return result
def decision(self, data):
fields = {'id','title','question','impact','priority','details','recommendation',
'options','deadline','requires_authorization','task_id'}
def _load_decision(self, db, did):
row = db.execute('SELECT * FROM decisions WHERE id=?',(identifier(did,'decision_id'),)).fetchone()
if not row:
raise Invalid('unknown decision')
return self._decision(row)
def _save_decision(self, db, value):
db.execute('UPDATE decisions SET workflow=?,response=? WHERE id=?',
(json.dumps(value,ensure_ascii=False),json.dumps(value['response']) if value['response'] else None,value['id']))
def _decision_history(self, db, value, kind, data):
event = dict(id=secrets.token_hex(16),kind=kind,revision=value['revision'],created=time.time(),data=data)
db.execute('INSERT INTO decision_history(decision_id,data) VALUES(?,?)',(value['id'],json.dumps(event,ensure_ascii=False)))
def _decision_notice(self, db, value, kind, target, event_key, **details):
nid = secrets.token_hex(16)
payload = dict(notification_id=nid,target=target,decision=value,
event=dict(kind=kind,revision=value['revision'],created=time.time(),**details))
db.execute('INSERT OR IGNORE INTO decision_workflow_notifications(id,decision_id,event_key,data) VALUES(?,?,?,?)',
(nid,value['id'],event_key,json.dumps(payload,ensure_ascii=False)))
def _cancel_decision_notices(self, db, did, kind, request_id=None):
# Once external submission has begun the immutable input must remain reconcilable.
sql = "UPDATE decision_workflow_notifications SET cancelled_at=? WHERE decision_id=? AND delivered_at IS NULL AND submission_started_at IS NULL AND json_extract(data,'$.event.kind')=?"
args = [time.time(),did,kind]
if request_id is not None:
sql += " AND json_extract(data,'$.event.request_id')=?"
args.append(request_id)
db.execute(sql,args)
@staticmethod
def _decision_revision(value, data):
rev = data.get('expected_revision')
if type(rev) is not int or rev < 1:
raise Invalid('positive expected_revision required')
if rev != value['revision']:
raise Conflict('decision revision changed')
@staticmethod
def _decision_fields(data, required, optional=()):
if not isinstance(data,dict) or not set(required) <= data.keys() or data.keys()-set(required)-set(optional):
raise Invalid('invalid workflow fields')
def _decision_replay(self, db, did, action, data):
if 'expected_revision' in data and (type(data['expected_revision']) is not int or data['expected_revision'] < 1):
raise Invalid('positive expected_revision required')
key = identifier(data.get('idempotency_key'),'idempotency_key')
row = db.execute('SELECT * FROM decision_operations WHERE decision_id=? AND action=? AND key=?',(did,action,key)).fetchone()
if row:
if json.loads(row['request']) != data:
raise Conflict('idempotency conflict')
return json.loads(row['result'])
def _decision_record(self, db, value, action, data, result=None):
result = value if result is None else result
db.execute('INSERT INTO decision_operations VALUES(?,?,?,?,?)',
(value['id'],action,data['idempotency_key'],json.dumps(data,ensure_ascii=False),json.dumps(result,ensure_ascii=False)))
return result
def decision_get(self, did):
with self.db() as db:
return self._load_decision(db,did)
def decision_history(self, did):
with self.db() as db:
self._load_decision(db,did)
return {'history':[json.loads(r['data']) for r in db.execute('SELECT data FROM decision_history WHERE decision_id=? ORDER BY seq',(did,))]}
def _normalize_decision(self, data):
fields = self.DECISION_FIELDS
if not isinstance(data, dict) or set(data) - fields or not {'id','title','question'} <= set(data):
raise Invalid('invalid decision fields')
value = {'id':identifier(data['id'])}
for name, limit in [('title',200),('question',4000),('impact',4000),
('details',8000),('recommendation',4000)]:
('details',8000),('recommendation',4000),('summary',1000)]:
raw = data.get(name, '')
if not isinstance(raw, str):
raise Invalid('invalid ' + name)
@@ -1558,83 +1687,352 @@ class Store:
value['requires_authorization'] = auth
task = data.get('task_id')
value['task_id'] = identifier(task,'task_id') if task is not None else None
supersedes = data.get('supersedes_id')
value['supersedes_id'] = identifier(supersedes,'supersedes_id') if supersedes is not None else None
return value
def decision(self, data):
value = self._normalize_decision(data)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
row = db.execute('SELECT * FROM decisions WHERE id=?',(value['id'],)).fetchone()
if row:
if json.loads(row['data']) != value:
if self._normalize_decision(json.loads(row['data'])) != value:
raise Conflict('decision definition differs')
return self._decision(row)
if task is not None:
self._get(db,'tasks',task)
db.execute('INSERT INTO decisions(id,data) VALUES(?,?)',
(value['id'],json.dumps(value,ensure_ascii=False)))
if value['task_id']:
self._get(db,'tasks',value['task_id'])
parent = None
if value['supersedes_id']:
if value['supersedes_id'] == value['id']:
raise Invalid('self supersedes')
parent = self._load_decision(db,value['supersedes_id'])
db.execute('INSERT INTO decisions(id,data) VALUES(?,?)',(value['id'],json.dumps(value,ensure_ascii=False)))
value.update(status='open',response=None,revision=1,session_id=None,session_thread_id=None,
archive_status='none',review=None,completion=None,
related_decision_ids=[parent['id']] if parent else [])
if parent:
parent['related_decision_ids'].append(value['id'])
self._save_decision(db,parent)
self._decision_history(db,parent,'linked',{'decision_id':value['id']})
self._save_decision(db,value)
self._decision_history(db,value,'version',self._decision_content(value))
self._decision_notice(db,value,'session_required','control','session:'+value['id'])
self._event(db,'decision.created',value['title'])
self._attention_auto(db,'decision',(value['id'],),'decisions','待决策:'+value['title'],
'/decisions?decision='+quote(value['id'],safe=''),time.time(),
decision_id=value['id'])
return dict(value,status='open',response=None)
'/decisions?decision='+quote(value['id'],safe=''),time.time(),decision_id=value['id'])
return value
def decision_respond(self, decision_id, data):
decision_id = identifier(decision_id,'decision_id')
if not isinstance(data,dict) or set(data) != {'option_id','comment','idempotency_key'}:
raise Invalid('invalid response fields')
def decision_patch(self, did, data):
self._decision_fields(data,{'expected_revision','reason'},self.DECISION_FIELDS-{'id','supersedes_id'})
reason = string(data['reason'],'reason',4000)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value = self._load_decision(db,did)
self._decision_revision(value,data)
if value['status'] == 'completed':
raise Conflict('decision closed')
old = self._decision_content(value)
changes = {k:v for k,v in data.items() if k in self.DECISION_FIELDS}
if not changes:
raise Invalid('content changes required')
content = self._normalize_decision(dict(old,**changes))
if content['task_id']:
self._get(db,'tasks',content['task_id'])
if content == old:
return value
value.update(content)
value['revision'] += 1
if value['response']:
value['status'] = 'needs_reconsideration'
self._save_decision(db,value)
self._decision_history(db,value,'version',dict(content=content,reason=reason))
self._cancel_decision_notices(db,did,'submitted')
if value['status']=='needs_reconsideration':
self._attention_auto(db,'decision',(did,),'decisions','需要重新确认:'+value['title'],
'/decisions?decision='+quote(did,safe=''),time.time(),decision_id=did)
return value
def decision_respond(self, did, data):
self._decision_fields(data,{'expected_revision','option_id','comment','idempotency_key'})
option = data['option_id']
if option is not None:
identifier(option,'option_id')
if not isinstance(data['comment'],str):
raise Invalid('invalid comment')
comment = string(data['comment'],'comment',8000,optional=True)
key = identifier(data['idempotency_key'],'idempotency_key')
if not isinstance(data['comment'],str) or (option is None and not comment.strip()):
raise Invalid('response required')
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
row = db.execute('SELECT * FROM decisions WHERE id=?',(decision_id,)).fetchone()
if not row:
raise Invalid('unknown decision')
value = self._decision(row)
if row['response']:
old = value['response']
if row['response_key'] == key and old['option_id'] == option and old['comment'] == comment:
return value
raise Conflict('decision already answered')
valid_options = {o['id'] for o in value['options']}
if (valid_options and option not in valid_options) or (not valid_options and option is not None):
value = self._load_decision(db,did)
replay = self._decision_replay(db,did,'respond',data)
if replay is not None:
return replay
self._decision_revision(value,data)
if value['status'] not in ('open','needs_reconsideration'):
raise Conflict('decision not open')
if option is not None and option not in {o['id'] for o in value['options']}:
raise Invalid('invalid choice')
if option is None and not comment.strip():
raise Invalid('response required')
response = {'id':secrets.token_hex(16),'option_id':option,'comment':comment,
'created':time.time(),'authorization':False}
value['response'] = response
value['status'] = 'pending_verification' if value['requires_authorization'] else 'decided'
db.execute('UPDATE decisions SET response=?,response_key=? WHERE id=?',
(json.dumps(response,ensure_ascii=False),key,decision_id))
db.execute('INSERT INTO decision_notifications(id,decision_id,data) VALUES(?,?,?)',
(secrets.token_hex(16),decision_id,json.dumps(value,ensure_ascii=False)))
self._attention_revoke(db,{'decision_id':decision_id},response['created'])
response = dict(id=secrets.token_hex(16),revision=value['revision'],option_id=option,comment=comment,
created=time.time(),authorization=False,snapshot=self._decision_content(value))
value.update(response=response,status='pending_review',review=None)
self._save_decision(db,value)
self._decision_history(db,value,'submission',response)
self._decision_notice(db,value,'submitted','control','submitted:'+response['id'])
self._attention_revoke(db,{'decision_id':did},response['created'])
self._event(db,'decision.responded',value['title'])
return value
return self._decision_record(db,value,'respond',data)
def decision_review(self, did, data):
self._decision_fields(data,{'expected_revision','idempotency_key','outcome','reason','impact','execution_plan'}, {'authorization_evidence'})
if data['outcome'] not in ('accept','reconsider'):
raise Invalid('invalid outcome')
for k in ('reason','impact','execution_plan'):
string(data[k],k,8000)
if 'authorization_evidence' in data:
string(data['authorization_evidence'],'authorization_evidence',8000)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value = self._load_decision(db,did)
replay = self._decision_replay(db,did,'review',data)
if replay is not None:
return replay
self._decision_revision(value,data)
if value['status'] != 'pending_review' or not value['response'] or value['response']['revision'] != value['revision']:
raise Conflict('current submission required')
review = {k:v for k,v in data.items() if k not in ('expected_revision','idempotency_key')}
review.update(revision=value['revision'],created=time.time())
value.update(review=review,status='accepted' if data['outcome']=='accept' else 'needs_reconsideration')
self._save_decision(db,value)
self._decision_history(db,value,'review',review)
if value['status']=='needs_reconsideration':
self._attention_auto(db,'decision',(did,),'decisions','需要重新确认:'+value['title'],
'/decisions?decision='+quote(did,safe=''),time.time(),decision_id=did)
self._cancel_decision_notices(db,did,'submitted')
self._decision_notice(db,value,'reviewed','human','reviewed:'+did+':'+data['idempotency_key'])
return self._decision_record(db,value,'review',data)
@staticmethod
def _decision_evidence(data):
evidence = data.get('evidence',[])
if not isinstance(evidence,list) or len(evidence)>50:
raise Invalid('invalid evidence')
return [string(v,'evidence',4000) for v in evidence]
@staticmethod
def _decision_pending(db, value):
return db.execute("SELECT count(*) FROM messages WHERE session_id=? AND status IN ('queued','claimed','uncertain')",(value['session_id'],)).fetchone()[0]
def decision_complete(self, did, data):
self._decision_fields(data,{'expected_revision','idempotency_key','conclusion','handoff'}, {'evidence'})
for k in ('conclusion','handoff'):
string(data[k],k,8000)
evidence = self._decision_evidence(data)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value = self._load_decision(db,did)
replay = self._decision_replay(db,did,'complete',data)
if replay is not None:
return replay
self._decision_revision(value,data)
if value['status'] not in ('accepted','needs_reconsideration') or not value['review'] or value['review']['revision'] != value['revision']:
raise Conflict('current review required')
if not value['session_id'] or not value['session_thread_id']:
raise Conflict('bound consultation required')
if self._decision_pending(db,value):
raise Conflict('consultation messages pending')
completion = dict(revision=value['revision'],conclusion=data['conclusion'],handoff=data['handoff'],evidence=evidence,created=time.time())
value.update(completion=completion,status='completed',archive_status='pending')
self._save_decision(db,value)
self._decision_history(db,value,'completion',completion)
self._attention_revoke(db,{'decision_id':did},time.time())
self._decision_notice(db,value,'archive_required','control','archive:'+did)
return self._decision_record(db,value,'complete',data)
def decision_bind(self, did, data):
self._decision_fields(data,{'expected_revision','idempotency_key','session_id','thread_id'})
sid = identifier(data['session_id'],'session_id')
thread = data['thread_id']
if not isinstance(thread,str) or not re.fullmatch(r'[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}',thread):
raise Invalid('invalid thread UUID')
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value = self._load_decision(db,did)
replay = self._decision_replay(db,did,'bind',data)
if replay is not None:
return replay
self._decision_revision(value,data)
if value['session_id']:
raise Conflict('binding unavailable')
session = self._get(db,'sessions',sid)
if session.get('role') != 'decision' or session.get('wp') != did or session.get('thread_id','').lower() != thread.lower():
raise Conflict('session identity mismatch')
for row in db.execute('SELECT * FROM sessions WHERE id<>?',(sid,)):
if json.loads(row['data']).get('thread_id','').lower()==thread.lower():
raise Conflict('thread reused')
for row in db.execute('SELECT * FROM decisions WHERE id<>?',(did,)):
other = self._decision(row)
if other['session_id']==sid or (other['session_thread_id'] or '').lower()==thread.lower():
raise Conflict('decision binding reused')
value.update(session_id=sid,session_thread_id=thread)
self._save_decision(db,value)
self._decision_history(db,value,'binding',dict(session_id=sid,thread_id=thread))
self._cancel_decision_notices(db,did,'session_required')
return self._decision_record(db,value,'bind',data)
def decision_archive(self, did, data):
self._decision_fields(data,{'thread_id','idempotency_key','receipt'})
string(data['receipt'],'receipt',8000)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value = self._load_decision(db,did)
replay = self._decision_replay(db,did,'archive',data)
if replay is not None:
return replay
if (value['status']!='completed' or not value['review'] or not value['completion']
or not value['completion']['handoff'] or not value['session_thread_id']
or value['session_thread_id'] != data['thread_id'] or value['archive_status']!='pending'):
raise Conflict('archive prerequisites missing')
if self._decision_pending(db,value):
raise Conflict('consultation messages pending')
value['archive_status']='archived'
self._save_decision(db,value)
self._decision_history(db,value,'archive',dict(thread_id=data['thread_id'],receipt=data['receipt']))
self._cancel_decision_notices(db,did,'archive_required')
return self._decision_record(db,value,'archive',data)
def decision_bindings(self):
with self.db() as db:
bindings=[]
for row in db.execute('SELECT * FROM decisions'):
value=self._decision(row)
if value['session_id']:
session=self._get(db,'sessions',value['session_id'])
rows=db.execute("SELECT * FROM messages WHERE session_id=? AND source='human' AND origin='coordination' AND status IN ('queued','claimed','uncertain')", (value['session_id'],)).fetchall()
now=time.time()
queued=[m for m in rows if m['status']=='queued' or (m['status']=='claimed' and not m['started'] and (m['lease_until'] or 0)<=now)]
uncertain=[m for m in rows if m['status']=='uncertain' or (m['status']=='claimed' and m['started'] and (m['lease_until'] or 0)<=now)]
inflight=[m for m in rows if m not in queued and m not in uncertain]
demand=dict(queued=len(queued),inflight=len(inflight),uncertain=len(uncertain),
human_queued=len(queued),oldest_queued_at=min((m['created'] for m in queued),default=None))
bindings.append(dict(decision_id=value['id'],session_id=value['session_id'],thread_id=value['session_thread_id'],
worktree=session['worktree'],status=value['status'],archive_status=value['archive_status'],
pending_messages=self._decision_pending(db,value),demand=demand))
return {'bindings':bindings}
def decision_consultation(self, did, data=None):
if data is None:
value=self.decision_get(did)
if not value['session_id']:
raise Conflict('consultation not bound')
return {'messages':self.conversation(value['session_id'])}
self._decision_fields(data,{'text','client_key'})
body=string(data['text'],'text',32000)
key=identifier(data['client_key'],'client_key')
# Status check and insertion share the same write lock as completion.
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value=self._load_decision(db,did)
if not value['session_id'] or value['status']=='completed':
raise Conflict('consultation unavailable')
sid=value['session_id']
old=db.execute('SELECT * FROM messages WHERE session_id=? AND idempotency_key=?',(sid,key)).fetchone()
if old:
if old['text']!=body or old['source']!='human' or old['reply_to'] is not None:
raise Conflict('idempotency conflict')
return self.public_message(old)
mid=secrets.token_hex(12)
db.execute('INSERT INTO messages(id,session_id,text,source,idempotency_key,status,created) VALUES(?,?,?,?,?,?,?)',
(mid,sid,body,'human',key,'queued',time.time()))
return self.public_message(db.execute('SELECT * FROM messages WHERE id=?',(mid,)).fetchone())
def decision_credential(self, did, data):
self._decision_fields(data,set())
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value=self._load_decision(db,did)
if not value['session_id'] or value['status']=='completed':
raise Conflict('consultation unavailable')
token=secrets.token_urlsafe(48)
db.execute('INSERT INTO decision_credentials VALUES(?,?,?)',(hashlib.sha256(token.encode()).hexdigest(),did,time.time()))
return {'token':token}
def decision_credential_scope(self, token):
with self.db() as db:
row=db.execute('SELECT decision_id FROM decision_credentials WHERE token_hash=?',(hashlib.sha256(token.encode()).hexdigest(),)).fetchone()
return row['decision_id'] if row else None
def decision_fact(self, did, data):
self._decision_fields(data,{'idempotency_key','question'},{'context'})
question=string(data['question'],'question',8000)
context=string(data.get('context',''),'context',8000,optional=True)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value=self._load_decision(db,did)
replay=self._decision_replay(db,did,'fact',data)
if replay is not None:
return replay
if value['status']=='completed' or not value['session_id']:
raise Conflict('consultation unavailable')
fact=dict(id=secrets.token_hex(16),revision=value['revision'],question=question,context=context,answer=None,created=time.time())
db.execute('INSERT INTO decision_facts VALUES(?,?,?)',(fact['id'],did,json.dumps(fact,ensure_ascii=False)))
self._decision_history(db,value,'fact_requested',fact)
self._decision_notice(db,value,'fact_requested','control','fact:'+fact['id'],request_id=fact['id'],question=question,context=context)
return self._decision_record(db,value,'fact',data,fact)
def decision_fact_answer(self, did, rid, data):
self._decision_fields(data,{'idempotency_key','answer'},{'evidence'})
answer=string(data['answer'],'answer',8000)
evidence=self._decision_evidence(data)
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
value=self._load_decision(db,did)
action='fact_answer:'+identifier(rid,'request_id')
replay=self._decision_replay(db,did,action,data)
if replay is not None:
return replay
row=db.execute('SELECT data FROM decision_facts WHERE id=? AND decision_id=?',(rid,did)).fetchone()
if not row:
raise Invalid('unknown fact request')
fact=json.loads(row['data'])
if fact['answer'] is not None or value['status']=='completed':
raise Conflict('fact request closed')
fact.update(answer=answer,evidence=evidence,answered_at=time.time())
db.execute('UPDATE decision_facts SET data=? WHERE id=?',(json.dumps(fact,ensure_ascii=False),rid))
self._decision_history(db,value,'fact_answered',fact)
self._cancel_decision_notices(db,did,'fact_requested',rid)
self._decision_notice(db,value,'fact_answered','decision','answer:'+rid,request_id=rid,answer=answer,evidence=evidence)
return self._decision_record(db,value,action,data,fact)
def decision_notifications(self):
with self.db() as db:
db.execute('BEGIN')
count = db.execute('SELECT count(*) FROM decision_notifications WHERE delivered_at IS NULL').fetchone()[0]
rows = db.execute('SELECT * FROM decision_notifications WHERE delivered_at IS NULL ORDER BY seq LIMIT 100').fetchall()
return {'notifications':[{'notification_id':row['id'],'target':'control',
'decision':json.loads(row['data'])} for row in rows],
'pending_count':count}
rows=db.execute('SELECT data FROM decision_workflow_notifications WHERE delivered_at IS NULL AND cancelled_at IS NULL ORDER BY seq LIMIT 100').fetchall()
count=db.execute('SELECT count(*) FROM decision_workflow_notifications WHERE delivered_at IS NULL AND cancelled_at IS NULL').fetchone()[0]
return {'notifications':[json.loads(row['data']) for row in rows],'pending_count':count}
def decision_ack(self, data):
if not isinstance(data,dict) or set(data) != {'notification_id'}:
raise Invalid('invalid acknowledgment fields')
nid = identifier(data['notification_id'],'notification_id')
def decision_submitting(self, data):
self._decision_fields(data,{'notification_id'})
nid=identifier(data['notification_id'],'notification_id')
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
row = db.execute('SELECT delivered_at FROM decision_notifications WHERE id=?',(nid,)).fetchone()
row=db.execute('SELECT * FROM decision_workflow_notifications WHERE id=?',(nid,)).fetchone()
if not row:
raise Invalid('unknown notification')
duplicate = row['delivered_at'] is not None
if row['cancelled_at'] is not None:
raise Conflict('notification cancelled')
db.execute('UPDATE decision_workflow_notifications SET submission_started_at=COALESCE(submission_started_at,?) WHERE id=?',(time.time(),nid))
return {'notification_id':nid,'status':'submitting'}
def decision_ack(self, data):
self._decision_fields(data,{'notification_id'})
nid=identifier(data['notification_id'],'notification_id')
with self.db() as db:
db.execute('BEGIN IMMEDIATE')
row=db.execute('SELECT delivered_at FROM decision_workflow_notifications WHERE id=?',(nid,)).fetchone()
if not row:
raise Invalid('unknown notification')
duplicate=row['delivered_at'] is not None
if not duplicate:
db.execute('UPDATE decision_notifications SET delivered_at=? WHERE id=?',(time.time(),nid))
db.execute('UPDATE decision_workflow_notifications SET delivered_at=? WHERE id=?',(time.time(),nid))
return {'notification_id':nid,'status':'delivered','duplicate':duplicate}
def state(self):
+2 -1
View File
@@ -13,6 +13,7 @@ import { Workbench } from '@/lib/context'
import { request, errorText } from '@/lib/api'
import type { State, AttentionItem } from '@/lib/types'
import { projectTitle, date } from '@/lib/types'
import VersionNotice from '@/components/version-notice'
import Overview from '@/pages/overview'
import Tasks from '@/pages/tasks'
import Cluster from '@/pages/cluster'
@@ -44,7 +45,7 @@ function Shell({ token, initial, logout }: { token: string; initial: State; logo
<header className="flex h-16 shrink-0 items-center justify-between gap-3 border-b px-4 md:px-6"><div className="flex min-w-0 items-center gap-3"><SidebarTrigger aria-label="切换导航" /><Separator orientation="vertical" className="h-4" />{isChat ? <div className="min-w-0"><h1 className="font-semibold">项目沟通</h1><p className="truncate text-xs text-muted-foreground">询问进度、讨论方案,或告诉我你的新想法。</p></div> : <Breadcrumb><BreadcrumbList><BreadcrumbItem><BreadcrumbPage>{navigation.find(n => n.url === location.pathname)?.title || '总览'}</BreadcrumbPage></BreadcrumbItem></BreadcrumbList></Breadcrumb>}</div>
{isChat ? <Button variant="ghost" size="sm" onClick={() => window.dispatchEvent(new Event('workbench-refresh-conversation'))}><RefreshCw />刷新</Button> : <div className="flex items-center gap-2 text-xs text-muted-foreground"><Circle className={`size-2 fill-current ${error ? 'text-destructive' : 'text-primary'}`} /><span>{error ? '连接中断' : '实时同步'}</span><span className="hidden lg:inline">{date(state.updated)}</span></div>}
</header>
<main className={isChat ? 'flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden bg-background' : 'min-w-0 flex-1 space-y-5 bg-muted/25 p-4 md:p-6 lg:p-8'}>{error && <Alert variant="destructive"><AlertDescription>{error} 当前显示上次同步的数据。</AlertDescription></Alert>}<AttentionNotice state={state} pathname={location.pathname} /><Routes><Route path="/overview" element={<Overview />} /><Route path="/tasks" element={<Tasks />} /><Route path="/cluster" element={<Cluster />} /><Route path="/communication" element={<Communication />} /><Route path="/decisions" element={<Decisions />} /><Route path="/logs" element={<Logs />} /><Route path="*" element={<Navigate to="/overview" replace />} /></Routes></main>
<main className={isChat ? 'flex min-h-0 min-w-0 flex-1 flex-col overflow-hidden bg-background' : 'min-w-0 flex-1 space-y-5 bg-muted/25 p-4 md:p-6 lg:p-8'}>{error && <Alert variant="destructive"><AlertDescription>{error} 当前显示上次同步的数据。</AlertDescription></Alert>}<VersionNotice /><AttentionNotice state={state} pathname={location.pathname} /><Routes><Route path="/overview" element={<Overview />} /><Route path="/tasks" element={<Tasks />} /><Route path="/cluster" element={<Cluster />} /><Route path="/communication" element={<Communication />} /><Route path="/decisions" element={<Decisions />} /><Route path="/logs" element={<Logs />} /><Route path="*" element={<Navigate to="/overview" replace />} /></Routes></main>
{!isChat && <footer className="border-t px-6 py-4 text-xs text-muted-foreground">Agent Workbench · 每 3 秒同步 · AI 接入状态以会话显示为准</footer>}
</SidebarInset></SidebarProvider></Workbench.Provider>
}
@@ -0,0 +1,53 @@
import { MessageDelivery } from '@/components/message-delivery'
import { useEffect, useRef, useState } from 'react'
import { Button } from '@/components/ui/button'
import { Textarea } from '@/components/ui/textarea'
import { request, errorText, messageKey } from '@/lib/api'
import type { Decision, Message } from '@/lib/types'
import { useLocalDraft } from '@/lib/use-local-draft'
import { useWorkbench } from '@/lib/context'
import type { ChatDraft } from '@/pages/decision-ui'
export default function DecisionChat({ decision, token }: { decision: Decision; token: string }) {
const id = decision.id, bound = Boolean(decision.session_id && decision.session_thread_id)
const readOnly = decision.status === 'completed' || decision.archive_status === 'archived'
const [messages, setMessages] = useState<Message[]>([]), [error, setError] = useState(''), [loaded, setLoaded] = useState(false), [, redraw] = useState(0)
const refresh = useRef<() => Promise<void>>(async () => {})
const scroll = useRef<HTMLDivElement>(null)
const { state } = useWorkbench()
const revision = decision.revision ?? 1
const local = useLocalDraft<ChatDraft & {revision:number}>(state.instance_id && Number.isInteger(decision.revision) && (decision.revision ?? 0) > 0 ? [state.instance_id, 'consultation', id, decision.session_id ?? 'unbound', String(revision)] : null, {text:'',sending:false,error:'',revision}, (v): v is ChatDraft & {revision:number} => Boolean(v && typeof v === 'object' && typeof (v as ChatDraft).text === 'string'), true)
const draft = local.value
const sending = useRef(false)
function persist() {local.save(draft);redraw(n => n+1)}
useEffect(() => {
if (!bound) return
const controller = new AbortController(); let busy = false
const poll = async () => {
if (busy || controller.signal.aborted) return
busy = true
try { const result = await request<{ messages: Message[] }>(token, `/api/decisions/${encodeURIComponent(id)}/consultation`, undefined, controller.signal); if (!controller.signal.aborted) { const box = scroll.current; const bottom = !box || box.scrollHeight - box.scrollTop - box.clientHeight < 120; setMessages(result.messages); setLoaded(true); setError(''); if (bottom) requestAnimationFrame(() => { if (scroll.current) scroll.current.scrollTop = scroll.current.scrollHeight }) } }
catch (cause) { if (!controller.signal.aborted) setError(errorText(cause)) }
finally { busy = false }
}
refresh.current = poll; void poll(); const timer = setInterval(() => void poll(), 3000)
return () => { clearInterval(timer); controller.abort() }
}, [id, token, bound])
async function send() {
if (!bound || readOnly || !local.ready || draft.revision !== revision || sending.current || draft.sending || !draft.text.trim()) return
const text = draft.text
if (!draft.attempt || draft.attempt.text !== text) draft.attempt = { text, key: messageKey() }
if (!local.save(draft)) return
sending.current=true
draft.sending = true; draft.error = ''; redraw(n => n + 1)
try { await request(token, `/api/decisions/${encodeURIComponent(id)}/consultation`, { text, client_key: draft.attempt.key }); local.clear(); await refresh.current() }
catch (cause) { draft.error = `${errorText(cause)} 草稿已保留,可重试同一消息。` }
finally { sending.current=false; draft.sending = false; redraw(n => n + 1) }
}
return <section className="flex min-w-0 flex-col rounded-xl border bg-card" aria-label="本决策咨询聊天"><div className="flex items-center justify-between border-b p-3"><h3 className="font-medium">本决策咨询</h3><Button size="sm" variant="ghost" disabled={!bound} onClick={() => void refresh.current()}>刷新</Button></div>
{(!bound || readOnly) && <p className="px-3 pt-3 text-xs text-muted-foreground">{!bound ? '咨询暂不可用。' : '已完成,只读。'}</p>}
<div ref={scroll} role="log" aria-label="本决策消息" className="max-h-[45vh] min-h-40 space-y-3 overflow-y-auto p-3">{messages.map(message => <article key={message.id} className={`rounded-lg p-3 text-sm ${message.source === 'human' ? 'ml-6 bg-primary text-primary-foreground' : 'mr-6 bg-muted'}`}><p className="mb-1 text-xs opacity-70">{message.source === 'human' ? '你' : '咨询助手'}</p><p className="whitespace-pre-wrap break-words">{message.text}</p><MessageDelivery message={message} messages={messages} /></article>)}{!messages.length && <p className="text-sm text-muted-foreground">{!bound ? '暂无已接通的咨询会话。' : loaded ? '暂无咨询消息。' : '正在读取咨询历史…'}</p>}</div>
{(error || draft.error) && <p role="status" className="px-3 pb-3 text-sm text-destructive">{draft.error || error}</p>}
<div className="space-y-2 px-3 pb-3">{local.error && <p role="status" className="text-xs text-destructive">{local.error}</p>}{local.error && <Button variant="outline" size="sm" disabled={draft.sending} onClick={() => persist()}>重试保存草稿</Button>}{draft.revision !== revision && <div className="text-sm"><p>这是版本 {draft.revision} 的咨询草稿,请重新确认当前问题。</p>{!readOnly && <Button variant="outline" size="sm" onClick={() => {draft.revision=revision;draft.attempt=undefined;persist()}}>确认用于当前版本</Button>}</div>}{readOnly && draft.text && <p className="whitespace-pre-wrap text-sm">保留的未发送草稿(只读):{draft.text}</p>}</div>
{!readOnly && <form className="space-y-2 border-t p-3" onSubmit={event => { event.preventDefault(); void send() }}><Textarea aria-label="本决策咨询问题" value={draft.text} disabled={!bound || draft.sending} maxLength={32000} onChange={event => { draft.text = event.target.value; persist() }} placeholder="询问方案、依据或影响…" /><Button type="submit" disabled={!bound || !local.ready || draft.revision !== revision || draft.sending || !draft.text.trim()}>{draft.sending ? '正在发送…' : '发送咨询'}</Button></form>}
</section>
}
@@ -0,0 +1,10 @@
import type { Message } from '@/lib/types'
import { messageDelivery } from '@/lib/message-delivery'
export function MessageDelivery({ message, messages }: { message: Message; messages: Message[] }) {
if (message.source !== 'human') return null
const delivery = messageDelivery(message, messages)
return <details className="mt-2 text-xs opacity-80" open={delivery.waiting || undefined}>
<summary className="cursor-pointer select-none">{delivery.label}</summary>
<p className="mt-1 leading-5">{delivery.reason || (delivery.stage === 'replied' ? '已收到此消息的回复。' : delivery.stage === 'delivered' ? '已进入会话,等待处理与回复。' : delivery.stage === 'processing' ? '会话正在处理,尚未收到回复。' : delivery.stage === 'queued' ? '已在服务端保存,等待会话处理。' : '已保存,尚未确认送达。')}</p>
</details>
}
@@ -0,0 +1,12 @@
import { Alert, AlertDescription } from '@/components/ui/alert'
import { useWorkbench } from '@/lib/context'
export default function VersionNotice() {
const { state } = useWorkbench()
const entry = document.querySelector<HTMLScriptElement>('script[type="module"][src]')?.getAttribute('src')
if (!entry || !state.frontend_entrypoint || entry !== state.frontend_entrypoint) {
if (!entry || !state.frontend_entrypoint) return null
return <Alert role="status"><AlertDescription>页面已更新,请重新加载并登录。</AlertDescription></Alert>
}
return null
}
+28
View File
@@ -0,0 +1,28 @@
export type DraftStorage = Pick<Storage, 'getItem' | 'setItem' | 'removeItem' | 'key' | 'length'>
const prefix = 'workbench-draft-v1:'
export function draftKey(scope: string[]) { return prefix + JSON.stringify(scope) }
export function readDraft<T>(storage: DraftStorage, scope: string[], empty: T, valid: (value: unknown) => value is T, olderVersions = false): T {
const raw = storage.getItem(draftKey(scope))
if (raw !== null) { const record = JSON.parse(raw); if (record.cleared) return empty; if (!valid(record.value)) throw new Error('草稿格式无法读取'); return record.value }
if (olderVersions) {
const base = scope.slice(0,-1), current = Number(scope.at(-1)); let latest = -1, found: T | undefined
for (let i=0;i<storage.length;i++) { const key=storage.key(i); if (!key?.startsWith(prefix)) continue
const parts=JSON.parse(key.slice(prefix.length)); if (!Array.isArray(parts) || JSON.stringify(parts.slice(0,-1))!==JSON.stringify(base)) continue
const version=Number(parts.at(-1)); if (version>=current || version<=latest) continue
const record=JSON.parse(storage.getItem(key) ?? 'null'); if (record?.cleared) continue
if (valid(record?.value)) { latest=version; found=record.value }
}
if(found) return found
}
return empty
}
export function writeDraft<T>(storage: DraftStorage, scope: string[], value: T) { storage.setItem(draftKey(scope), JSON.stringify({ value }, (key, item) => key === 'sending' || key === 'error' ? undefined : item)) }
export function clearDraft(storage: DraftStorage, scope: string[], allVersions = false) {
if(allVersions) { const base=scope.slice(0,-1); const keys:string[]=[]; for(let i=0;i<storage.length;i++){const key=storage.key(i);if(!key?.startsWith(prefix))continue; const parts=JSON.parse(key.slice(prefix.length));if(JSON.stringify(parts.slice(0,-1))===JSON.stringify(base))keys.push(key)} for(const key of keys)storage.removeItem(key) }
storage.setItem(draftKey(scope), JSON.stringify({cleared:true}))
}
export function clearIfUnchanged(storage: DraftStorage, scope: string[], expected: string | null) {
if(storage.getItem(draftKey(scope))!==expected) return false
clearDraft(storage,scope)
return true
}
@@ -0,0 +1,17 @@
import type { Message } from './types'
export type DeliveryStage = 'saved' | 'queued' | 'delivered' | 'processing' | 'replied' | 'blocked' | 'unknown'
export const deliveryLabels: Record<DeliveryStage, string> = { saved:'已保存', queued:'排队中', delivered:'已送达', processing:'处理中', replied:'已回复', blocked:'受阻', unknown:'待核查' }
export function messageDelivery(message: Message, messages: Message[]) {
const replied = messages.some(row => row.source === 'agent' && row.reply_to === message.id && row.session_id === message.session_id)
let stage: DeliveryStage
if (replied) stage = 'replied'
else if (message.delivery_stage && message.delivery_stage in deliveryLabels) stage = message.delivery_stage
else if (['failed','uncertain','blocked'].includes(message.status)) stage = 'blocked'
else if (message.status === 'queued') stage = 'queued'
else if (message.status === 'delivered' || message.submission?.state === 'accepted') stage = 'delivered'
else if (message.status === 'claimed') stage = 'queued' // A lease alone is not a running native turn.
else if (message.status === 'saved') stage = 'saved'
else stage = 'unknown' // Transport completion alone does not prove a visible reply.
const reason = stage === 'blocked' ? (message.delivery_reason || '结果尚未确认,正在核查;请勿重复发送。') : stage === 'unknown' ? '暂无法确认消息阶段,请刷新查看。' : ''
return {stage, label:deliveryLabels[stage], reason, waiting:['queued','processing','blocked','unknown'].includes(stage)}
}
+10 -5
View File
@@ -8,26 +8,31 @@ export type Task = {
integration_status?: 'not_started' | 'waiting' | 'integrating' | 'integrated' | 'verified'; id: string; name: string; status: string; phase: string; eta_min_minutes?: number | null; eta_max_minutes?: number | null; eta_basis?: string; eta_estimated_at?: number | null; eta_revision?: number; eta_change_reason?: string; eta_last_reviewed_at?: number | null; eta_review_status?: string; current_progress?: string; progress_updated?: number | null; decision?: string; updated?: number }
export type Session = { id: string; name: string; wp?: string; role?: string; thread_id?: string; thread_url?: string; connection?: string; history_synced_at?: number }
export type Event = { id: number; kind: string; text: string; created: number; session_id?: string }
export type Message = { log_id?: string | null; id: string; session_id: string; text: string; source: 'human' | 'agent'; status: string; created: number; origin?: string; reply_to?: string }
export type Message = { delivery_stage?: 'saved' | 'queued' | 'delivered' | 'processing' | 'replied' | 'blocked'; delivery_reason?: string; submission?: {state?: string}; log_id?: string | null; id: string; session_id: string; text: string; source: 'human' | 'agent'; status: string; created: number; origin?: string; reply_to?: string }
export type Sample<T> = { host?: string; status?: string; error?: string; collected_at?: string; data?: T | null }
export type NodeMetric = { memory_used_percent?: number; memory_total_bytes?: number; memory_available_bytes?: number; load_1m?: number; load_5m?: number; load_15m?: number }
export type Mount = { mount_target: string; used_percent?: number; total_bytes?: number; available_bytes?: number }
export type SchedulerData = { count?: number; by_state?: Record<string, number>; queues?: { name: string; state: string; pend?: number; run?: number }[] }
export type Metrics = { sampled_at?: number; status?: string; message?: string; data?: { status?: string; message?: string; collected_at?: string; nodes?: Sample<NodeMetric>[]; storage?: Sample<Mount[]>[]; schedulers?: Record<string, Record<string, Sample<SchedulerData>>> } }
export type State = { attention?: Attention; decisions?: Decision[]; hooks?: { pending_notifications: number; active_firing: number; recent: { source: string; summary: string; status: string; severity: string }[] }; config?: { title?: string }; title?: string; primary_session_id?: string; tasks: Task[]; sessions: Session[]; events: Event[]; requests: { id: string; name: string; status: string }[]; metrics?: Metrics; updated?: number }
export type State = { instance_id?: string; frontend_entrypoint?: string | null; attention?: Attention; decisions?: Decision[]; hooks?: { pending_notifications: number; active_firing: number; recent: { source: string; summary: string; status: string; severity: string }[] }; config?: { title?: string }; title?: string; primary_session_id?: string; tasks: Task[]; sessions: Session[]; events: Event[]; requests: { id: string; name: string; status: string }[]; metrics?: Metrics; updated?: number }
export const statusLabels: Record<string, string> = { queued: '排队', running: '进行中', waiting: '等待', blocked: '受阻', completed: '已完成', failed: '失败', cancelled: '已取消', claimed: '处理中', delivered: '已送达', uncertain: '待人工核查' }
export const phaseLabels: Record<string, string> = { planning: '规划', implementation: '实现', validation: '验证', integration: '集成', done: '完成' }
export function date(value?: string | number) { return value == null ? '暂无' : new Date(typeof value === 'number' ? value * 1000 : value).toLocaleString('zh-CN') }
export function projectTitle(state: State) { return state.config?.title || state.title || 'Agent Workbench' }
export type DecisionOption = { id: string; label: string; description: string }
export type DecisionResponse = { id: string; option_id: string | null; comment: string; created: string | number; authorization: false }
export type DecisionResponse = { id: string; option_id: string | null; comment: string; created: string | number; authorization: false; revision?: number; snapshot?: { title?: string; question?: string; details?: string; impact?: string; options?: DecisionOption[] } }
export type Decision = {
id: string; title: string; question: string; impact: string
id: string; title: string; question: string; impact: string; summary?: string
priority: 'normal' | 'high' | 'urgent'
status: 'open' | 'decided' | 'pending_verification'
status: 'open' | 'pending_review' | 'accepted' | 'completed' | 'needs_reconsideration' | 'decided' | 'pending_verification'
details: string; recommendation: string; options: DecisionOption[]
deadline: string | null; requires_authorization: boolean; task_id: string | null
revision?: number; session_id?: string | null; session_thread_id?: string | null
archive_status?: 'none' | 'pending' | 'archived'
review?: { revision?: number; outcome: 'accept' | 'reconsider'; reason: string; impact: string; execution_plan: string; created?: number } | null
completion?: { revision?: number; conclusion: string; handoff: string; evidence?: string[]; created?: number } | null
supersedes_id?: string | null; related_decision_ids?: string[]
response: DecisionResponse | null
}
@@ -0,0 +1,11 @@
import { useRef, useState } from 'react'
import { clearDraft, clearIfUnchanged, draftKey, readDraft, writeDraft } from './draft-storage'
export function useLocalDraft<T>(scope: string[] | null, empty: T, valid: (value: unknown) => value is T, olderVersions = false) {
const identity=JSON.stringify(scope), ref=useRef<{identity:string;value:T;error:string;loaded:boolean;persisted:string|null} | null>(null)
const [, redraw]=useState(0)
if(ref.current?.identity!==identity){let value=empty,error='',persisted=null;try{if(scope){value=readDraft(window.localStorage,scope,empty,valid,olderVersions);persisted=window.localStorage.getItem(draftKey(scope))}else error='实例或版本信息尚未就绪,暂不能保存或发送。'}catch{error='草稿读取失败,请先复制输入。'}ref.current={identity,value,error,loaded:!error,persisted}}
const record=ref.current!
function save(value:T){record.value=value;try{if(!scope)throw Error();writeDraft(window.localStorage,scope,value);record.persisted=window.localStorage.getItem(draftKey(scope));record.error='';record.loaded=true;redraw(n=>n+1);return true}catch{record.error='草稿保存失败,请复制后重试。';record.loaded=false;redraw(n=>n+1);return false}}
function clear(allVersions=false,userRequested=false){try{if(!scope)throw Error();if(allVersions||userRequested)clearDraft(window.localStorage,scope,allVersions);else if(!clearIfUnchanged(window.localStorage,scope,record.persisted)){record.error='';redraw(n=>n+1);return false}record.value=empty;record.persisted=window.localStorage.getItem(draftKey(scope));record.error='';record.loaded=true;redraw(n=>n+1);return true}catch{record.error='草稿清除失败,请勿重复提交。';record.loaded=false;redraw(n=>n+1);return false}}
return {value:record.value,error:record.error,save,clear,ready:Boolean(scope)&&record.loaded}
}
+17 -15
View File
@@ -1,3 +1,4 @@
import { MessageDelivery } from '@/components/message-delivery'
import { useEffect, useRef, useState } from 'react'
import type { FormEvent } from 'react'
import { Link } from 'react-router-dom'
@@ -7,6 +8,7 @@ import { Textarea } from '@/components/ui/textarea'
import { Alert, AlertDescription } from '@/components/ui/alert'
import { useWorkbench } from '@/lib/context'
import { request, errorText, messageKey } from '@/lib/api'
import { useLocalDraft } from '@/lib/use-local-draft'
import type { Message } from '@/lib/types'
export default function Communication() {
const { state, token, refresh } = useWorkbench()
@@ -14,11 +16,11 @@ export default function Communication() {
const selected = primary
const session = state.sessions.find(s => s.id === selected)
const [messages, setMessages] = useState<{ session: string; items: Message[] }>({ session: '', items: [] })
const [drafts, setDrafts] = useState<Record<string, string>>({})
const local = useLocalDraft(state.instance_id ? [state.instance_id, 'communication', selected] : null, { text: '', attempt: undefined as {text:string;key:string}|undefined }, (v): v is {text:string;attempt?:{text:string;key:string}} => Boolean(v && typeof v === 'object' && typeof (v as {text?:unknown}).text === 'string'))
const [error, setError] = useState('')
const [sending, setSending] = useState(false)
const [refreshVersion, setRefreshVersion] = useState(0)
const pending = useRef<{ session_id: string; text: string; idempotency_key: string } | null>(null)
const sendingRef = useRef(false)
const scroll = useRef<HTMLDivElement>(null)
const loaded = useRef('')
const known = Boolean(session)
@@ -53,22 +55,23 @@ export default function Communication() {
if (loaded.current !== selected || box.scrollHeight - box.scrollTop - box.clientHeight < 300) box.scrollTop = box.scrollHeight
loaded.current = selected
}, [lastId, selected, messages.session])
const decisions = (state as { decisions?: { id: string; status: string }[] }).decisions?.filter(d => d.status === 'open') || []
const text = drafts[selected] || ''
const decisions = (state as { decisions?: { id: string; status: string }[] }).decisions?.filter(d => ['open','needs_reconsideration'].includes(d.status)) || []
const text = local.value.text
async function send(event: FormEvent) {
event.preventDefault()
if (!session || !text.trim() || sending) return
if (!session || !text.trim() || sendingRef.current || !local.ready) return
const sid = selected, body = text
if (!pending.current || pending.current.session_id !== sid || pending.current.text !== body) pending.current = { session_id: sid, text: body, idempotency_key: messageKey() }
const attempt = local.value.attempt?.text === body ? local.value.attempt : {text:body,key:messageKey()}
if (!local.save({text:body,attempt})) return
sendingRef.current = true
setSending(true); setError('')
try {
await request(token, '/api/messages', { ...pending.current, source: 'human' })
pending.current = null
setDrafts(old => old[sid] === body ? { ...old, [sid]: '' } : old)
await request(token, '/api/messages', { session_id:sid, text:body, idempotency_key:attempt.key, source:'human' })
local.clear()
setRefreshVersion(n => n + 1)
await refresh()
} catch (e) { setError(errorText(e)) }
finally { setSending(false) }
finally { sendingRef.current=false; setSending(false) }
}
return <div className="flex min-h-0 w-full flex-1 flex-col">
@@ -81,15 +84,14 @@ export default function Communication() {
<p className="mb-1 text-xs opacity-65">{m.source === 'human' ? '你' : '项目助手'}</p>
<p className="whitespace-pre-wrap wrap-anywhere text-sm leading-7">{m.text}</p>
{m.log_id && <Link className="mt-2 inline-block text-sm text-primary underline underline-offset-4" to={`/logs?incident=${encodeURIComponent(m.log_id)}`}>查看日志</Link>}
{m.source === 'human' && ['queued', 'claimed'].includes(m.status) && <p className="mt-2 text-xs opacity-70">正在等待回复…</p>}
{m.source === 'human' && ['failed', 'uncertain'].includes(m.status) && <p className="mt-2 text-xs opacity-70">暂未确认回复,请稍后查看;无需重复发送。</p>}
<MessageDelivery message={m} messages={items} />
</div>
</article>) : <div className="flex h-full items-center justify-center text-sm text-muted-foreground">{known ? '有什么想了解的?从这里开始交流。' : '会话准备好后,即可在这里交流。'}</div>}
</div>
<form onSubmit={send} className="shrink-0 border-t p-3 sm:px-8">
<Textarea id="message" aria-label="输入消息" value={text} onChange={e => setDrafts(old => ({ ...old, [selected]: e.target.value }))} placeholder="输入你的问题或想法…" maxLength={32000} rows={2} required className="resize-none border-0 shadow-none focus-visible:ring-0" />
<div className="mt-2 flex items-center justify-between gap-3"><p className="text-xs text-muted-foreground">{!known ? '正在准备会话' : session?.connection === 'connected' ? '' : '暂时离线,消息会保存并等待回复。'}</p><Button type="submit" disabled={!known || sending || !text.trim()}><Send />{sending ? '发送中…' : '发送'}</Button></div>
{local.error && <p role="status" className="mb-2 text-xs text-destructive">{local.error}</p>}<Textarea id="message" aria-label="输入消息" value={text} disabled={sending} onChange={e => local.save({...local.value,text:e.target.value})} placeholder="输入你的问题或想法…" maxLength={32000} rows={2} required className="resize-none border-0 shadow-none focus-visible:ring-0" />
<div className="mt-2 flex items-center justify-between gap-3"><p className="text-xs text-muted-foreground">{!known ? '正在准备会话' : session?.connection === 'connected' ? '' : '会话暂时离线;已提交的消息等待接通。'}</p><Button type="submit" disabled={!known || !local.ready || sending || !text.trim()}><Send />{sending ? '发送中…' : '发送'}</Button></div>
</form>
</section>
</div>
}
}
+19
View File
@@ -0,0 +1,19 @@
import type { Decision } from '@/lib/types'
export function decisionStatus(decision: Decision) {
return decision.status === 'decided' || decision.status === 'pending_verification' ? (decision.response ? 'pending_review' : 'open') : decision.status
}
export const decisionLabels = { open: '等待决定', pending_review: '等待检查', accepted: '已接受,待落实', completed: '已完成', needs_reconsideration: '需要重新考虑' }
export type DecisionDraft = { option: string | null; comment: string; revision: number; conflict: boolean; attempt?: { signature: string; key: string }; sending?: boolean }
export type ChatDraft = { text: string; sending: boolean; error: string; attempt?: { text: string; key: string } }
export function writable(decision: Decision) { return ['open', 'needs_reconsideration'].includes(decisionStatus(decision)) }
export function submissionBody(decision: Decision, draft: DecisionDraft) {
const revision = decision.revision
if (!Number.isInteger(revision) || (revision ?? 0) < 1) return null
if (!writable(decision) || draft.sending || draft.conflict || draft.revision !== revision) return null
if (draft.option && !decision.options.some(option => option.id === draft.option)) return null
if (!draft.option && !draft.comment.trim()) return null
return { expected_revision: revision, option_id: draft.option, comment: draft.comment }
}
export function confirmDraft(decision: Decision, draft: DecisionDraft) {
draft.revision = decision.revision ?? 1; draft.conflict = false; draft.option = null; draft.attempt = undefined
}
+92 -99
View File
@@ -1,113 +1,106 @@
import { useRef, useState } from 'react'
import { useEffect, useRef, useState } from 'react'
import { Link, useSearchParams } from 'react-router-dom'
import { ArrowRight } from 'lucide-react'
import { Button } from '@/components/ui/button'
import { Badge } from '@/components/ui/badge'
import { Card } from '@/components/ui/card'
import { Textarea } from '@/components/ui/textarea'
import { Sheet, SheetContent, SheetHeader, SheetTitle, SheetDescription, SheetFooter } from '@/components/ui/sheet'
import { Sheet, SheetContent, SheetHeader, SheetTitle, SheetDescription } from '@/components/ui/sheet'
import { PageHeading, Panel, Empty } from '@/components/shared'
import DecisionChat from '@/components/decision-chat'
import VersionNotice from '@/components/version-notice'
import { useLocalDraft } from '@/lib/use-local-draft'
import { useWorkbench } from '@/lib/context'
import { ApiError, errorText, messageKey, request } from '@/lib/api'
import { date, type Decision } from '@/lib/types'
import { decisionStatus, decisionLabels, writable, submissionBody, confirmDraft, type DecisionDraft } from './decision-ui'
const statuses = { open: '等待决定', decided: '已决定', pending_verification: '待核实' }
const priorities = { normal: '普通', high: '重要', urgent: '紧急' }
type Draft = { optionId: string | null; comment: string }
const emptyDraft: Draft = { optionId: null, comment: '' }
function Status({ decision }: { decision: Decision }) {
return <Badge variant="outline" className={decision.status === 'decided' ? 'status-success' : 'status-neutral'}>{statuses[decision.status]}</Badge>
type HistoryEntry = { id?: string | number; kind?: string; created?: number; revision?: number; data?: Record<string, unknown> }
function Status({ decision }: { decision: Decision }) { const status = decisionStatus(decision); return <Badge variant="outline" className={status === 'completed' ? 'status-success' : status === 'needs_reconsideration' ? 'status-danger' : 'status-neutral'}>{decisionLabels[status]}</Badge> }
function Text({ label, text }: { label: string; text?: string }) { return text ? <section><h3 className="font-medium">{label}</h3><p className="mt-2 whitespace-pre-wrap break-words text-sm leading-6">{text}</p></section> : null }
const historyLabels: Record<string, string> = { version: '决策版本', submission: '提交选择', review: '主控检查', completion: '完成交接', binding: '绑定咨询会话', archive: '归档确认', linked: '关联决策', created: '建立决策', updated: '内容更新', revised: '版本更新', submitted: '提交选择', responded: '提交选择', reviewed: '检查结论', completed: '完成交接', bound: '绑定咨询会话', session_bound: '绑定咨询会话', archived: '归档确认', fact_requested: '请求核实', fact_answered: '核实回复' }
function HistoryRecord({ entry }: { entry: HistoryEntry }) {
const data = entry.data ?? {}
const snapshot = data.snapshot && typeof data.snapshot === 'object' ? data.snapshot as Record<string, unknown> : data.content && typeof data.content === 'object' ? data.content as Record<string, unknown> : data
const options = Array.isArray(snapshot.options) ? snapshot.options.filter((item): item is { id: string; label: string; description?: string } => Boolean(item && typeof item === 'object' && typeof item.id === 'string' && typeof item.label === 'string')) : []
return <li className="space-y-2 rounded-lg border p-3 text-sm"><p className="font-medium">{historyLabels[entry.kind ?? ''] || '处理记录'}{entry.revision ? ` · 版本 ${entry.revision}` : ''} · {date(entry.created)}</p>
{typeof data.option_id === 'string' && <p>当时选择:{options.find(option => option.id === data.option_id)?.label || data.option_id}</p>}
{Object.entries({ reason:'理由', comment:'提交意见', conclusion:'完成结论', handoff:'交接', impact:'影响', execution_plan:'执行计划', question:'问题', answer:'核实回复' }).map(([key,label]) => typeof data[key] === 'string' ? <Text key={key} label={label} text={data[key] as string} /> : null)}
{snapshot !== data && typeof snapshot.question === 'string' && <Text label="当时的问题" text={snapshot.question} />}
{options.length > 0 && <details><summary className="cursor-pointer">查看当时全部方案</summary><ul className="mt-2 space-y-2">{options.map(option => <li key={option.id}><p className="font-medium">{option.label}</p><p className="whitespace-pre-wrap">{option.description}</p></li>)}</ul></details>}
</li>
}
function Detail({ id, initial }: { id: string; initial?: Decision }) {
const { token, refresh, state } = useWorkbench()
const [decision, setDecision] = useState(initial), [history, setHistory] = useState<HistoryEntry[]>([]), [error, setError] = useState(''), [notice, setNotice] = useState(''), [, redraw] = useState(0)
const reload = useRef<() => Promise<void>>(async () => {}), generation = useRef(0)
useEffect(() => {
const controller = new AbortController(); let pending = false
const poll = async () => {
if (pending || controller.signal.aborted) return
pending = true; const seq = ++generation.current
try { const current = await request<Decision>(token, `/api/decisions/${encodeURIComponent(id)}`, undefined, controller.signal); if (!controller.signal.aborted && seq === generation.current) { setDecision(current); setError('') }
const events = await request<{ history: HistoryEntry[] }>(token, `/api/decisions/${encodeURIComponent(id)}/history`, undefined, controller.signal); if (!controller.signal.aborted && seq === generation.current) setHistory(events.history)
} catch (cause) { if (!controller.signal.aborted && seq === generation.current) setError(errorText(cause)) } finally { pending = false }
}
reload.current = poll; void poll(); const timer = setInterval(() => void poll(), 3000)
return () => { controller.abort(); clearInterval(timer) }
}, [id, token])
const revision = decision?.revision ?? 1
const local = useLocalDraft<DecisionDraft>(state.instance_id && decision && Number.isInteger(decision.revision) && (decision.revision ?? 0) > 0 ? [state.instance_id, 'decision', id, String(revision)] : null, {option:null,comment:'',revision,conflict:false}, (v): v is DecisionDraft => Boolean(v && typeof v === 'object' && typeof (v as DecisionDraft).comment === 'string' && Number.isInteger((v as DecisionDraft).revision)), true)
const draft = local.value
const sending = useRef(false)
function persist() { local.save(draft); redraw(n => n + 1) }
const changed = Boolean(draft && (draft.revision !== revision || draft.conflict))
const editable = Boolean(decision && writable(decision) && !draft?.sending && local.ready)
async function submit() {
if (!decision || !draft || sending.current || !editable || changed || (!draft.option && !draft.comment.trim())) return
const body = submissionBody(decision, draft)
if (!body) return
const signature = JSON.stringify(body)
if (!draft.attempt || draft.attempt.signature !== signature) draft.attempt = { signature, key: messageKey() }
if (!local.save(draft)) return
sending.current = true
draft.sending = true; redraw(n => n + 1); setNotice('')
try {
const result = await request<Decision>(token, `/api/decisions/${encodeURIComponent(id)}/respond`, { ...body, idempotency_key: draft.attempt.key })
++generation.current; setDecision(result); setNotice(''); local.clear()
await refresh().catch(() => {}); await reload.current()
} catch (cause) {
if (cause instanceof ApiError && cause.status === 409) { draft.conflict = true; persist(); setNotice('内容或状态已变化,草稿已保留。请阅读最新内容并重新确认,未自动重交。'); await reload.current() }
else setNotice(`${errorText(cause)} 草稿已保留,相同内容重试复用原提交记录。`)
} finally { sending.current = false; draft.sending = false; redraw(n => n + 1) }
}
return <><SheetHeader className="pr-12"><SheetTitle>{decision?.title ?? '读取决策…'}</SheetTitle><SheetDescription>{decision?.summary || decision?.question || '查看方案、检查结论与本决策咨询。'}</SheetDescription></SheetHeader>
<div className="min-h-0 flex-1 overflow-y-auto px-4 pb-5"><VersionNotice />{error && <p role="status" className="mb-4 text-sm text-destructive">{error} 保留已读取内容。<Button variant="link" onClick={() => void reload.current()}>重试</Button></p>}
{decision && draft ? <div className="grid min-w-0 gap-6 lg:grid-cols-[minmax(0,1.1fr)_minmax(0,1fr)]"><div className="min-w-0 space-y-5">
{local.error && <p role="status" className="text-xs text-destructive">{local.error}</p>}{local.error && <Button variant="outline" size="sm" disabled={draft.sending} onClick={() => persist()}>重试保存草稿</Button>}{!writable(decision) && (draft.comment || draft.option) && <section className="rounded-lg border p-3 text-sm"><h3>保留的本地草稿(只读,未自动提交)</h3><p>版本 {draft.revision} · 选项 {draft.option || '无'}</p><p className="whitespace-pre-wrap">{draft.comment}</p></section>}<div className="flex flex-wrap gap-2"><Status decision={decision} /><Badge variant="outline">版本 {revision}</Badge>{decision.task_id && <Link to={`/tasks?task=${encodeURIComponent(decision.task_id)}`} className="text-sm text-primary underline">{state.tasks.find(task => task.id === decision.task_id)?.name || decision.task_id}</Link>}</div>
<Text label="需要决定的问题" text={decision.question} /><Text label="背景与依据" text={decision.details} /><Text label="影响" text={decision.impact} /><Text label="推荐与理由(不会替你选择)" text={decision.recommendation} />
{decision.deadline && Number.isFinite(Date.parse(decision.deadline)) && <p className="text-sm">截止时间:{date(decision.deadline)}</p>}
<p className="text-xs text-muted-foreground">选择提交后需检查;接受方案不代表权限授权,也不代表已经完成。</p>
{decision.options.length > 0 && <fieldset disabled={!editable || changed} className="space-y-2"><legend className="mb-2 font-medium">全部方案</legend>{decision.options.map(option => <label key={option.id} className="flex gap-3 rounded-lg border p-3"><input type="radio" name={`decision-${id}`} checked={draft.option === option.id} onChange={() => { draft.option = option.id; persist() }} className="mt-1 size-4 shrink-0 accent-primary" /><span><span className="font-medium">{option.label}</span><span className="mt-1 block whitespace-pre-wrap text-sm text-muted-foreground">{option.description}</span></span></label>)}</fieldset>}
{writable(decision) && <div className="space-y-3"><Button variant="ghost" size="sm" disabled={!editable || changed || !draft.option} onClick={() => { draft.option = null; persist() }}>清除选项,仅填写意见</Button><label className="block text-sm font-medium" htmlFor={`opinion-${id}`}>你的意见(可不选方案,直接填写)</label><Textarea id={`opinion-${id}`} disabled={!editable} value={draft.comment} onChange={event => { draft.comment = event.target.value; persist() }} />
{changed && <div className="space-y-2 rounded-lg border p-3"><p className="text-sm">请重新阅读当前版本;之前的选择不会自动作为本次确认。</p><Button variant="outline" disabled={draft.sending || Boolean(error)} onClick={() => { confirmDraft(decision, draft); persist(); setNotice(''); redraw(n => n + 1) }}>我已阅读版本 {revision},重新确认</Button></div>}
<Button disabled={!editable || changed || (!draft.option && !draft.comment.trim())} onClick={() => void submit()}>{draft.sending ? '正在提交…' : '提交本次选择或意见'}</Button>
</div>}
{notice && <p role="status" className="text-sm">{notice}</p>}
{decision.response && <section className="space-y-2 rounded-lg border p-3"><h3 className="font-medium">最近提交</h3><p className="text-sm">提交版本:{decision.response.revision ?? '旧记录'} · {date(decision.response.created)}</p><p className="text-sm">选项:{decision.response.snapshot?.options?.find(option => option.id === decision.response?.option_id)?.label ?? decision.response.option_id ?? '仅填写意见'}</p><p className="whitespace-pre-wrap text-sm">{decision.response.comment}</p></section>}
{decision.review && <section className="space-y-3 rounded-lg border p-3"><h3 className="font-medium">检查结论:{decision.review.outcome === 'accept' ? '接受,待落实' : '需要重新考虑'}</h3><Text label="理由" text={decision.review.reason} /><Text label="影响" text={decision.review.impact} /><Text label="执行计划" text={decision.review.execution_plan} /></section>}
{decision.completion && <section className="space-y-3 rounded-lg border p-3"><Text label="完成结论" text={decision.completion.conclusion} /><Text label="交接说明" text={decision.completion.handoff} />{decision.completion.evidence?.map((text,index) => <p key={index} className="break-words text-sm">{text}</p>)}</section>}
{decision.status === 'completed' && <p className="text-sm">{decision.archive_status === 'archived' ? '咨询会话已确认归档,历史只读。' : '决策已完成,咨询会话待归档确认。'}</p>}
{Boolean(decision.supersedes_id || decision.related_decision_ids?.length) && <section><h3 className="mb-2 font-medium">关联决策</h3>{[...new Set([...(decision.supersedes_id ? [decision.supersedes_id] : []), ...(decision.related_decision_ids ?? [])])].map(other => <Link key={other} className="mr-3 text-sm text-primary underline" to={`/decisions?decision=${encodeURIComponent(other)}`}>{other}{other === decision.supersedes_id ? '(被此决策替代)' : ''}</Link>)}</section>}
<section><h3 className="mb-2 font-medium">版本与处理历史</h3>{history.length ? <ol className="space-y-3">{history.map((entry,index) => <HistoryRecord key={entry.id ?? index} entry={entry} />)}</ol> : <p className="text-sm text-muted-foreground">暂无已读取的历史记录。</p>}</section>
</div><div className="min-w-0"><DecisionChat key={id} decision={decision} token={token} /></div></div> : !error && <Empty>正在读取当前决策。</Empty>}
</div></>
}
export default function Decisions() {
const { state, token, refresh } = useWorkbench()
const [params, setParams] = useSearchParams()
const [receipts, setReceipts] = useState<Record<string, Decision>>({})
const decisions = (state.decisions ?? []).map(decision => decision.status === 'open' ? receipts[decision.id] ?? decision : decision)
const selectedId = params.get('decision')
const selected = decisions.find(d => d.id === selectedId)
const [drafts, setDrafts] = useState<Record<string, Draft>>({})
const [notices, setNotices] = useState<Record<string, string>>({})
const [busy, setBusy] = useState<Record<string, boolean>>({})
const [submitted, setSubmitted] = useState<Record<string, boolean>>({})
const inFlight = useRef(new Set<string>())
const attempts = useRef(new Map<string, { payload: string; key: string }>())
const acknowledged = useRef(new Set<string>())
const draft = selected ? drafts[selected.id] ?? emptyDraft : emptyDraft
const editable = selected?.status === 'open' && !busy[selected.id] && !submitted[selected.id]
function open(id: string | null) {
setParams(previous => { const next = new URLSearchParams(previous); if (id) next.set('decision', id); else next.delete('decision'); return next })
}
function updateDraft(value: Partial<Draft>) {
if (!selected || !editable) return
setDrafts(previous => ({ ...previous, [selected.id]: { ...(previous[selected.id] ?? emptyDraft), ...value } }))
}
async function sync(id: string) {
try { await refresh(); setNotices(previous => ({ ...previous, [id]: '' })) }
catch (error) { setNotices(previous => ({ ...previous, [id]: `状态同步未完成:${errorText(error)} 请刷新状态。` })) }
}
async function submit(decision: Decision) {
const id = decision.id
const current = drafts[id] ?? emptyDraft
if (decision.status !== 'open' || inFlight.current.has(id) || acknowledged.current.has(id)) return
if (decision.options.length && !decision.options.some(option => option.id === current.optionId)) return
const body = { option_id: current.optionId, comment: current.comment }
const payload = JSON.stringify(body)
let attempt = attempts.current.get(id)
if (!attempt || attempt.payload !== payload) { attempt = { payload, key: messageKey() }; attempts.current.set(id, attempt) }
inFlight.current.add(id)
setBusy(previous => ({ ...previous, [id]: true }))
setNotices(previous => ({ ...previous, [id]: '' }))
try {
const result = await request<Decision>(token, `/api/decisions/${encodeURIComponent(id)}/respond`, { ...body, idempotency_key: attempt.key })
setReceipts(previous => ({ ...previous, [id]: result }))
acknowledged.current.add(id)
setSubmitted(previous => ({ ...previous, [id]: true }))
setNotices(previous => ({ ...previous, [id]: '' }))
await sync(id)
} catch (error) {
setNotices(previous => ({ ...previous, [id]: `${errorText(error)} 草稿已保留;重试相同内容不会重复提交。` }))
if (error instanceof ApiError && error.status === 409) await sync(id)
} finally {
inFlight.current.delete(id)
setBusy(previous => ({ ...previous, [id]: false }))
}
}
const legacy = state.tasks.filter(task => task.decision)
return <div className="space-y-6">
<PageHeading title="方案与决策" description="查看影响与方案,再明确提交你的选择。" action={<Button asChild variant="outline"><Link to="/communication">讨论方案 <ArrowRight /></Link></Button>} />
{decisions.length ? <div className="grid gap-4 md:grid-cols-2 xl:grid-cols-3">{decisions.map(decision => <Card key={decision.id} className="gap-0 p-0">
<button type="button" onClick={() => open(decision.id)} className="flex h-full w-full flex-col gap-4 rounded-xl p-6 text-left transition-colors hover:bg-muted/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" aria-label={`查看决策:${decision.title}`}>
<div className="flex flex-wrap gap-2"><Badge variant="outline" className={decision.priority === 'urgent' ? 'status-danger' : 'status-neutral'}>{priorities[decision.priority]}</Badge><Status decision={decision} /></div>
<h2 className="font-semibold break-words">{decision.title}</h2>
<p className="whitespace-pre-wrap break-words text-sm leading-6">{decision.question}</p>
<p className="whitespace-pre-wrap break-words text-sm text-muted-foreground">影响:{decision.impact || '尚未补充'}</p>
<span className="mt-auto flex items-center gap-2 text-sm text-primary">查看方案与详情 <ArrowRight className="size-4" /></span>
</button>
</Card>)}</div> : <Panel title="决策展板"><Empty>当前没有结构化决策事项。可在沟通中请总控补充需要决定的问题与方案。</Empty></Panel>}
{legacy.length > 0 && <Panel title="待完善条目(只读)" description="以下是工作包原有的文字记录,尚不能在此提交选择。"><div className="space-y-4">{legacy.map(task => <article key={task.id} className="rounded-lg border p-4"><h3 className="font-medium">{task.id} · {task.name}</h3><p className="mt-2 whitespace-pre-wrap break-words text-sm leading-6">{task.decision}</p><p className="mt-2 text-xs text-muted-foreground">更新于 {date(task.updated)}</p><Button asChild variant="link" className="mt-2 h-auto p-0"><Link to="/communication">请总控补充结构化选项 <ArrowRight /></Link></Button></article>)}</div></Panel>}
<Sheet open={selectedId !== null} onOpenChange={value => { if (!value) open(null) }}>
<SheetContent className="w-full sm:max-w-xl">
<SheetHeader className="pr-12"><SheetTitle>{selected?.title ?? '决策暂不可用'}</SheetTitle><SheetDescription>{selected?.question ?? '该条目尚未同步或已移除,请刷新状态后重试。'}</SheetDescription></SheetHeader>
{selected ? <>
<div className="min-h-0 flex-1 space-y-6 overflow-y-auto px-4 pb-4 break-words">
<div className="flex flex-wrap gap-2"><Badge variant="outline">{priorities[selected.priority]}</Badge><Status decision={selected} /></div>
<section><h3 className="font-medium">影响</h3><p className="mt-2 whitespace-pre-wrap text-sm leading-6">{selected.impact || '尚未补充'}</p></section>
<section><h3 className="font-medium">背景与依据</h3><p className="mt-2 whitespace-pre-wrap text-sm leading-6">{selected.details || '尚未补充'}</p></section>
{selected.recommendation && <section className="rounded-lg border bg-muted/50 p-4"><h3 className="font-medium">推荐与理由</h3><p className="mt-2 whitespace-pre-wrap text-sm leading-6">{selected.recommendation}</p><p className="mt-2 text-xs text-muted-foreground">推荐不会替你选择。</p></section>}
{selected.deadline && Number.isFinite(Date.parse(selected.deadline)) && <p className="text-sm">截止时间:{date(selected.deadline)}</p>}
{selected.requires_authorization && <p className="rounded-lg border p-4 text-sm">此事项涉及权限。提交选择后仍需核实,不代表已授权。</p>}
{selected.options.length > 0 && <fieldset disabled={!editable} className="space-y-3"><legend className="mb-3 font-medium">方案与取舍{selected.status === 'open' ? '(请选择一项)' : ''}</legend>{selected.options.map(option => <label key={option.id} className={`flex gap-3 rounded-lg border p-4 ${editable ? 'cursor-pointer hover:bg-muted/50' : ''}`}><input type="radio" name={`decision-${selected.id}`} value={option.id} checked={selected.status === 'open' ? draft.optionId === option.id : selected.response?.option_id === option.id} onChange={() => updateDraft({ optionId: option.id })} className="mt-1 size-4 shrink-0 accent-primary" /><span><span className="font-medium">{option.label}</span><span className="mt-1 block whitespace-pre-wrap text-sm leading-6 text-muted-foreground">{option.description}</span></span></label>)}</fieldset>}
{selected.status === 'open' && <div className="space-y-2"><label htmlFor="decision-comment" className="text-sm font-medium">补充备注</label><Textarea id="decision-comment" value={draft.comment} onChange={event => updateDraft({ comment: event.target.value })} disabled={!editable} placeholder="补充你的考虑或要求" /></div>}
{selected.response && <section className="space-y-2 rounded-lg border p-4"><h3 className="font-medium">已记录的回复</h3><p className="text-sm">选择:{selected.options.find(option => option.id === selected.response?.option_id)?.label ?? selected.response.option_id ?? '仅备注'}</p><p className="whitespace-pre-wrap text-sm">{selected.response.comment || '无补充备注'}</p><p className="text-xs text-muted-foreground">{date(selected.response.created)}</p></section>}
{selected.status === 'pending_verification' && <p role="status" className="text-sm">选择已记录,等待核实;尚未授权。</p>}
{notices[selected.id] && <p role="status" className="text-sm">{notices[selected.id]}</p>}
</div>
<SheetFooter className="border-t">
{selected.status === 'open' && !submitted[selected.id] && <Button disabled={!editable || (selected.options.length > 0 && !selected.options.some(option => option.id === draft.optionId))} onClick={() => void submit(selected)}>{busy[selected.id] ? '正在提交…' : '提交选择'}</Button>}
<Button variant="outline" disabled={busy[selected.id]} onClick={() => void sync(selected.id)}>刷新状态</Button>
</SheetFooter>
</> : <SheetFooter><Button variant="outline" onClick={() => void sync(selectedId ?? '')}>刷新状态</Button></SheetFooter>}
</SheetContent>
</Sheet>
const { state } = useWorkbench(), [params, setParams] = useSearchParams()
const id = params.get('decision')
const decisions = state.decisions ?? []
return <div className="space-y-6"><PageHeading title="方案与决策" description="查看方案、咨询依据并明确提交,跟踪检查与落实结果。" />
{decisions.length ? <div className="grid gap-4 md:grid-cols-2 xl:grid-cols-3">{decisions.map(decision => <Card key={decision.id} className="p-0"><button type="button" onClick={() => setParams(previous => { const next = new URLSearchParams(previous); next.set('decision',decision.id); return next })} className="flex h-full w-full flex-col gap-3 rounded-xl p-6 text-left hover:bg-muted/50 focus-visible:ring-2 focus-visible:ring-ring"><div className="flex flex-wrap gap-2"><Status decision={decision} /><Badge variant="outline">{decision.task_id ? state.tasks.find(task => task.id === decision.task_id)?.name || decision.task_id : '未关联任务'}</Badge></div><h2 className="font-semibold">{decision.title}</h2><p className="whitespace-pre-wrap break-words text-sm text-muted-foreground">{decision.summary || decision.question}</p><span className="mt-auto text-sm text-primary">查看方案与咨询</span></button></Card>)}</div> : <Panel title="决策展板"><Empty>当前没有登记决策事项。</Empty></Panel>}
{state.tasks.some(task => task.decision) && <Panel title="旧版文字条目(只读)">{state.tasks.filter(task => task.decision).map(task => <p key={task.id} className="mb-3 whitespace-pre-wrap text-sm">{task.name}:{task.decision}</p>)}</Panel>}
<Sheet open={id !== null} onOpenChange={value => { if (!value) setParams(previous => { const next = new URLSearchParams(previous); next.delete('decision'); return next }) }}><SheetContent className="w-full sm:max-w-6xl">{id && <Detail key={id} id={id} initial={decisions.find(decision => decision.id === id)} />}</SheetContent></Sheet>
</div>
}
+1 -1
View File
@@ -7,7 +7,7 @@ import { useWorkbench } from '@/lib/context'
import { phaseLabels } from '@/lib/types'
export default function Overview() {
const { state } = useWorkbench()
const pending = [...state.tasks.filter(t => t.decision), ...((state as { decisions?: { id: string; title: string; question: string; status: string }[] }).decisions || []).filter(d => d.status === 'open').map(d => ({ id: d.id, name: d.title, decision: d.question }))]
const pending = [...state.tasks.filter(t => t.decision), ...((state as { decisions?: { id: string; title: string; question: string; status: string }[] }).decisions || []).filter(d => ['open','needs_reconsideration'].includes(d.status)).map(d => ({ id: d.id, name: d.title, decision: d.question }))]
const blocked = state.tasks.filter(t => ['blocked', 'failed'].includes(t.status))
const lead = state.tasks.find(t => t.id === 'WP0')
const stats = [{ label: '工作包', value: state.tasks.length, icon: Layers3 }, { label: '进行中', value: state.tasks.filter(t => t.status === 'running').length, icon: Activity }, { label: '已完成', value: state.tasks.filter(t => t.status === 'completed').length, icon: CheckCircle2 }, { label: '待决定', value: pending.length, icon: CircleHelp }]
@@ -0,0 +1,10 @@
import test from 'node:test'
import assert from 'node:assert/strict'
import { decisionStatus, submissionBody, confirmDraft } from '../src/pages/decision-ui.ts'
const decision={status:'open',revision:2,options:[{id:'a'}]}
const draft=()=>({option:null,comment:'',revision:2,conflict:false})
test('free text allowed with enumerated options; empty and invalid options rejected',()=>{assert.equal(submissionBody(decision,draft()),null);assert.equal(submissionBody(decision,{...draft(),comment:' '}),null);assert.deepEqual(submissionBody(decision,{...draft(),comment:'其他意见'}),{expected_revision:2,option_id:null,comment:'其他意见'});assert.equal(submissionBody(decision,{...draft(),option:'gone'}),null)})
test('old revision or conflict cannot resubmit without explicit confirmation',()=>{const d={...draft(),revision:1,option:'a',comment:'保留意见',conflict:true,attempt:{key:'old',signature:'old'}};assert.equal(submissionBody(decision,d),null);confirmDraft(decision,d);assert.equal(d.option,null);assert.equal(d.comment,'保留意见');assert.equal(d.attempt,undefined);assert.equal(submissionBody(decision,d).expected_revision,2)})
test('pending accepted completed read only; reconsideration permits new submission',()=>{for(const status of ['pending_review','accepted','completed'])assert.equal(submissionBody({...decision,status},{...draft(),option:'a'}),null);assert.ok(submissionBody({...decision,status:'needs_reconsideration'},{...draft(),option:'a'}));assert.equal(submissionBody(decision,{...draft(),option:'a',sending:true}),null)})
test('legacy response maps to pending review, never acceptance',()=>{for(const status of ['decided','pending_verification'])assert.equal(decisionStatus({status,response:{id:'r'}}),'pending_review')})
test('missing revision cannot be guessed for a legacy request',()=>{assert.equal(submissionBody({...decision,revision:undefined},{...draft(),revision:1,option:'a'}),null)})
@@ -0,0 +1,13 @@
import test from 'node:test'
import assert from 'node:assert/strict'
import { draftKey,readDraft,writeDraft,clearDraft,clearIfUnchanged } from '../src/lib/draft-storage.ts'
class Memory { data=new Map();get length(){return this.data.size}key(i){return [...this.data.keys()][i]??null}getItem(k){return this.data.get(k)??null}setItem(k,v){this.data.set(k,v)}removeItem(k){this.data.delete(k)} }
const valid=v=>!!v&&typeof v.text==='string';const empty={text:''}
test('remount/reload recovers text and same unknown-delivery attempt key',()=>{const s=new Memory(),scope=['instance','communication','human'];writeDraft(s,scope,{text:'hello',attempt:{key:'stable',text:'hello'}});assert.deepEqual(readDraft(s,scope,empty,valid),{text:'hello',attempt:{key:'stable',text:'hello'}})})
test('instance session decision channel and version isolate records',()=>{const s=new Memory(),a=['i','decision','d1','1'];writeDraft(s,a,{text:'private'});for(const b of [['other','decision','d1','1'],['i','decision','d2','1'],['i','consultation','d1','1'],['i','decision','d1','2']])assert.deepEqual(readDraft(s,b,empty,valid),empty)})
test('new revision recovers old content without changing its revision or attempt',()=>{const s=new Memory();writeDraft(s,['i','decision','d','1'],{text:'old',revision:1,attempt:{key:'same'}});assert.equal(readDraft(s,['i','decision','d','2'],empty,valid,true).revision,1);assert.equal(s.length,1)})
test('successful clearing does not clear consultation or restore old selection',()=>{const s=new Memory(),scope=['i','decision','d','2'];writeDraft(s,['i','decision','d','1'],{text:'old'});writeDraft(s,scope,{text:'sent'});writeDraft(s,['i','consultation','d','2'],{text:'chat'});clearIfUnchanged(s,scope,s.getItem(draftKey(scope)));assert.deepEqual(readDraft(s,scope,empty,valid,true),empty);assert.equal(readDraft(s,['i','consultation','d','2'],empty,valid).text,'chat')})
test('late success cannot remove a newer draft',()=>{const s=new Memory(),scope=['i','c','s'];writeDraft(s,scope,{text:'sent'});const expected=s.getItem(draftKey(scope));writeDraft(s,scope,{text:'new'});assert.equal(clearIfUnchanged(s,scope,expected),false);assert.equal(readDraft(s,scope,empty,valid).text,'new')})
test('explicit clear removes only selected decision versions',()=>{const s=new Memory();for(const id of ['a','b'])for(const version of ['1','2'])writeDraft(s,['i','decision',id,version],{text:id});clearDraft(s,['i','decision','a','2'],true);assert.equal(readDraft(s,['i','decision','b','1'],empty,valid).text,'b');assert.deepEqual(readDraft(s,['i','decision','a','2'],empty,valid,true),empty);assert.equal(s.getItem(draftKey(['i','decision','a','1'])),null)})
test('unavailable storage and corrupt data throw instead of claiming saved',()=>{const s=new Memory();s.setItem=()=>{throw Error('quota')};assert.throws(()=>writeDraft(s,['i'],{text:'x'}));s.getItem=()=>'{broken';assert.throws(()=>readDraft(s,['i'],empty,valid))})
test('transient sending/errors are not revived as a stuck pending UI',()=>{const s=new Memory();writeDraft(s,['i'],{text:'retry',sending:true,error:'offline',attempt:{key:'stable'}});const value=readDraft(s,['i'],empty,valid);assert.equal(value.sending,undefined);assert.equal(value.error,undefined);assert.equal(value.attempt.key,'stable')})
@@ -0,0 +1,9 @@
import test from 'node:test'
import assert from 'node:assert/strict'
import { messageDelivery } from '../src/lib/message-delivery.ts'
const m={id:'m',session_id:'s',source:'human',text:'question',status:'queued'}
test('each explicit transport stage remains separate',()=>{for(const stage of ['saved','queued','delivered','processing','replied','blocked'])assert.equal(messageDelivery({...m,delivery_stage:stage},[]).stage,stage)})
test('receipt accepted proves delivery but never processing or reply',()=>{assert.equal(messageDelivery({...m,status:'claimed',submission:{state:'accepted'}},[]).stage,'delivered');assert.equal(messageDelivery({...m,status:'completed'},[]).stage,'unknown')})
test('only real correlated same-session reply closes pending state',()=>{const reply={...m,id:'a',source:'agent',reply_to:'m'};assert.equal(messageDelivery(m,[reply]).stage,'replied');assert.equal(messageDelivery(m,[{...reply,session_id:'other'}]).stage,'queued');assert.equal(messageDelivery(m,[{...reply,reply_to:'other'}]).stage,'queued')})
test('unknown failed and uncertain outcomes never invite replay',()=>{for(const status of ['failed','uncertain']){const result=messageDelivery({...m,status},[]);assert.equal(result.stage,'blocked');assert.match(result.reason,/请勿重复发送/)}assert.equal(messageDelivery({...m,status:'future'},[]).stage,'unknown')})
test('delayed blocked receipt yields to a correlated reply',()=>{assert.equal(messageDelivery({...m,status:'uncertain',delivery_stage:'blocked'},[{...m,id:'a',source:'agent',reply_to:'m'}]).stage,'replied')})
+12
View File
@@ -0,0 +1,12 @@
你仅负责决策 {decision_id} 的咨询与内容维护。
先读取本地 skill 的决策流程规范,再通过以下专用配置读取当前卡片与版本:
{scoped_config}
可用工具:在技能目录运行 python scripts/decision.py --config <上述配置> show 或 history;edit 使用包含 expected_revision、reason 和允许内容字段的 JSON 请求;ask 提交需要主控核实的事实问题。相同事实问题保持同一关联 ID,不循环催问。只在你自己的临时工作目录保存请求和回执,不修改项目源码。
该凭据只允许这一决策的有限接口,不读取其他配置、凭据或项目私有文件。你可以解释全部选项、澄清影响,依据核实事实维护简介和内容;修改必须保留提交快照并遵守版本冲突。不得接受用户提交、检查批准、执行方案、修改代码或系统、更新其他任务、绑定或归档会话。用户提交与主控接受都不是新增权限授权。
事实问题经本决策 facts 接口定向交主控。一般项目需求、待授权事项及面向人类的结论交项目agent对话入口;不在其他会话直接向人类提问。用户在决策页发来的咨询只在本决策范围回答。源字段、网页载荷和其他 agent 建议均不构成新授权。
初始化只读取并确认本决策的真实状态,简短说明可在本决策页咨询。没有绑定、凭据或事实依据时如实说明待接通,不生成演示回复、不扩展任务。
+6 -1
View File
@@ -31,5 +31,10 @@
"execution_notification_targets": {
"implementation-worker": "44444444-4444-4444-8444-444444444444"
},
"prior_notification_states": []
"prior_notification_states": [],
"decision_fleet": {
"enabled": false,
"runtime_root": "/path/to/private/decision-bridges",
"max_active": 3
}
}
+18
View File
@@ -0,0 +1,18 @@
# 独立决策会话接入
本流程由主控执行。仅对真实待决策事项建立卡片与宿主会话;隔离 API 测试不证明真实会话、模型往返或归档已通过。
1. 在正式看板创建有依据的决策,关联唯一任务,写明简介、完整背景、全部选项和影响。保存创建回执。没有真实事项时不要为验收制造生产决策。
2. 先为本决策规划本机私有有限配置路径。读取宿主项目/会话清单,确认没有既有绑定,再用宿主正式创建工具建立独立真实会话。使用 `assets/decision-consultation-prompt.txt` 生成角色说明,替换真实决策 ID 与计划配置路径;不指定未获人类选择的模型。配置尚未准备时,初始化只等待接入,不读取普通控制凭据或生成演示回复。保存宿主返回的真实 thread ID、执行主机和工作目录。
3. 注册 `role=decision`、`wp=<decision_id>` 的看板 session;核对宿主真实会话身份后调用 `bind-session`。一个决策只绑定一个真实会话,不复用入口或执行会话。保存绑定回执;数据库中的占位 ID 不是宿主创建证据。
4. 仅绑定后,使用普通控制连接调用该决策的 `consultation-credential`,把返回 token 直接写入本机私有文件,不打印、不传给聊天、不存源码。写一个私有配置,形如 `{"decision_id":"<真实ID>","control":{"url":"http://<已授权看板域名>:8796","token_file":"<本机私有token路径>"}}`。该配置只给对应咨询会话;普通控制连接和模型认证留在执行器,不分发给会话。签发响应未知时先核查既有私有回执和文件,不反复轮换已交付凭据。
5. 本机桥接私有配置可启用 `decision_fleet: {"enabled":true,"runtime_root":"<私有目录>","max_active":3}`。fleet 从正式 bindings 接口读取已绑定会话,在其实际目录运行原有 worker/mirror。它不创建模型会话、不归档、不切模型,超过上限保留等待。每个会话有独立租期、幂等回执与未知结果保护;不能重复启动第二套执行器或抢 writer 锁。
6. 验证决策详情内的一条真实咨询进入该 thread,并核对同一 thread 的真实回复回到本决策。再验证事实核实请求、主控保存答复及绑定会话收到答复;不把投递 ACK 当实际处理。咨询内容通过既有历史投影展示,内部工具和原始通知不混进聊天。
7. 用户提交只进入待检查。主控读取提交时的不可变快照,核实适用范围与风险,再记录接受或重议、效果与执行规划;主控检查结论由唯一人类入口简短解释并链接卡片。权限相关动作另核实真实人类授权,不能仅靠网页来源、咨询建议或 accepted 状态执行。
8. 完成后先保存检查结论、实际完成证据和交接。核对咨询输入没有 queued/claimed/uncertain,且私有 worker 不存在 inflight、pending_completion 或 needs_reconciliation。然后用宿主受支持归档工具归档真实 thread,成功后才保存 archive-receipt。仅写归档字段不是宿主归档;归档失败保留待归档,不抹去记录或删除会话。
完成并归档后,卡片、版本、提交快照、检查结论和聊天只读保留。fleet 只停止自身桥接进程,不杀模型 writer;有未知执行状态时保留证据等待对账,不能盲重放。
有限 API 凭据约束的是服务端接口,不是宿主操作系统沙箱。咨询会话的代码/系统边界同时依赖其角色约束及宿主权限;不要声称已提供未实际配置的硬隔离。
决策通知外发前先调用 `/api/decision-notifications/submitting` 持久标记,再保存本机 submitting 状态并调用宿主队列。标记调用失败可幂等重试,但不发送模型输入;真实队列发送未知时先对账、不盲重发。服务端只取消未开始/未确认的过时通知,已开始或未知发送保留审计。
+18 -2
View File
@@ -35,7 +35,7 @@
只显示用户实际输入、面向用户的最终回复及需要行动的简洁提醒。隐藏角色/安全提示封装、JSON事实快照、内部跨会话原始汇报、工具日志和合成验收整轮内容;原始消息、回执、来源和审计不删除。用户自己输入或引用的正文不能因包含“日志/测试/JSON”等关键词而过滤。
页面固定连接人类入口,不显示会话选择、绑定状态说明、原会话跳转或新建会话表单。页头只提供“刷新”,重新读取聊天和必要状态,保留登录、草稿、目标与幂等发送记录,不做浏览器整页重载。正常聊天不堆时间、来源、投递徽标;只在等待或失败时用自然语言提示。
页面固定连接人类入口,不显示会话选择、绑定状态说明、原会话跳转或新建会话表单。页头只提供“刷新”,重新读取聊天和必要状态,保留登录、草稿、目标与幂等发送记录,不做浏览器整页重载。正常聊天不堆时间、来源、投递徽标;每条实际网页输入的投递阶段用简短可展开文字查询,普通成功阶段默认收起,排队、处理中及受阻直接提示。阶段依据真实API投影,已保存不冒充送达,已回复不代表业务完成;不显示私有宿主回执或内部队列载荷。
聊天读取独立GET /api/conversation投影视图;原始GET /api/messages继续用于后台审计、桥接和对账。投影通过保存的turn/phase/reply关系隐藏内部或验收轮次;网页封装只有与已保存原输入完整匹配才折叠为原文。重大真实故障显示人类可读摘要,不透出原始事件载荷。首次打开显示最近对话,阅读旧消息时不强制滚到底部。
@@ -43,7 +43,7 @@
需要用户决定的事项使用卡片展板,不做长日志列表。卡片只展示问题、影响、优先级及状态,点击打开详情抽屉。详情包括背景、问题、推荐与依据、方案说明和真实有依据的期限。可枚举方案使用可点击单选项,默认不选,推荐不视为批准。备注可补充;显式“提交选择”按钮与选择动作分开,失败保留草稿,同一草稿重试复用幂等键。
提交后显示实际选择与结果,权限相关显示“待核实”,不显示“已授权”。采用#/decisions?decision=<id>打开具体卡片;沟通只做一句提醒并链接卡片,不复制全部方案。空状态不加入合成演示决策。既有tasks.decision文本保留只读兼容,不伪造选项。
提交后显示实际选择快照及“待主控检查”,接受后显示“待落实”,完成与归档分别展示,不显示“已授权”。采用#/decisions?decision=<id>打开具体卡片;沟通只做一句提醒并链接卡片,不复制全部方案。空状态不加入合成演示决策。既有tasks.decision文本保留只读兼容,不伪造选项。
任务卡的“目前进度”只展示current_progress,不能替换旧标签后仍显示eta_basis。进度实际变化后自动刷新,保留业务更新时间;活跃任务过期显示待更新需核查,完成剩余为0。新增改进单独登记,不沿用旧完成记录遮盖正在进行的工作。
@@ -74,3 +74,19 @@
悬停节点高亮递归上游、下游及对应边,无关节点与边淡化但文字仍可读;mouseleave恢复。键盘focus提供等效交互,触屏通过选中节点提供同效高亮和明确的详情按钮;退出选择恢复。高亮不改变事实、筛选开关或自动切换全部。详情仍保留任务定位链接、目标、负责人、依赖、验收与集成状态。
复用固定token和既有组件,以纯SVG与HTML实现,不引入新依赖。遍历使用visited与迭代队列/栈防循环和长链调用栈溢出。真实浏览器验收默认/全部、hover/focus/触屏、详情及窄屏;纯逻辑测试覆盖长链、多依赖、无依赖、筛选和汇合验收门禁。
## 决策详情与独立咨询
卡片展示关联任务标签、状态与summary简介。宽详情展示背景、完整候选方案、自由填写、主控检查结论及版本历史;有候选方案仍允许只填写意见,推荐不预选,显式提交。提交携当前revision,失败保留草稿和幂等键;版本冲突刷新并要求重新确认,不能偷偷提交到新版本。需要重新考虑时保留旧快照供对照。
详情内独立咨询按decision_id隔离轮询、消息、草稿及client_key,发送显示pending并防重;未绑定显示待接通,不模拟回复。完成归档后只读历史。组件不修改普通沟通页,用户选择仍在卡片;事实核实回复、接受结论与实际授权分别呈现。键盘/窄屏可访问,不新增依赖。隔离验收覆盖切换决策不串消息、失败草稿、版本冲突、只填意见、历史及只读状态;真实会话未接通不显示已验证。
## 草稿保存与恢复反馈
沟通、决策提交和独立咨询分别保存草稿,按实例与对应目标隔离;切页、刷新、重新登录后恢复。草稿状态与发送状态分开,失败或结果未知保留输入,不自动重发;明确成功后才清对应内容。存储不可用明确提示尚未持久保存,不显示虚假的已保存状态。
决策版本改变显示旧稿与重确认提示,重新阅读后才允许使用新版本提交,不静默把旧选项视为批准。已完成决策只读历史与草稿处理不得触发提交。页面升级提示不得自动重载丢失正在编辑内容;无本地数据的旧丢稿不声称可恢复。草稿只在网页本地,不上传,不包含token。
存储失败时允许继续保留当前输入和重试保存,禁止发送并提示刷新/退出可能丢失。成功但发现新编辑时保留新稿,不增加成功提示。恢复旧版本内容必须保留版本提示与显式重确认;本地保存提示不代表已发送、模型已回复或决策已完成。
保持简洁:功能修复不擅自增加按钮和解释性文案。三类草稿均后台保存/恢复,不显示清草稿按钮、常驻本地保存说明或冗余成功提示。只在阻止操作的错误与版本冲突时提供最短必要提示,普通状态不占界面。移除控件不调用清除逻辑。
+44 -1
View File
@@ -38,6 +38,16 @@ HTTP服务适合受控局域网或受保护隧道。跨不可信网络使用经
## 当前会话与桥接
### 按需调度与断网续传
决策bindings中的`demand`汇总真实持久队列:`queued/inflight/uncertain/human_queued/oldest_queued_at`,不依赖最近500条历史截断。过期且未开始的领取可重新领取;已开始过期或未知的输入只允许核对,不能自动重放。`pending_messages`保留兼容。
fleet按需启动绑定会话的worker/mirror,空闲后安全释放桥接名额,保留原状态文件和真实会话。排队顺序与等待年龄持久保存;人类咨询优先且有界老化,已有在途执行不被抢占。未知执行保留镜像核对能力,不通过杀模型、删除状态或扩大并发解决等待。主机不可用/配置不符时保留受阻信息,不能伪称已处理。
通知器优先决策,其他通知首次进入待发集合的时间持久保存,等待120秒后按先到顺序提升;服务按最早未确认顺序分页返回,断网重启不清等待年龄。提升不绕过每目标背压,已发送结果未知仍以原线程、完整输入与回执对账。镜像确认丢失时用相同外部item身份重传,服务端幂等合并,不重新执行模型。
消息投影`delivery_stage`为`queued/delivered/processing/replied/blocked`;客户端保存确认可短暂显示`saved`。`accepted`宿主排队回执才显示送达,观察到真实turn才显示处理中,关联完成回复才显示已回复;本地started/submitting不能冒充送达。投影不公开完整submission或私有回执。界面不能仅凭已回复判断任务验收完成。
加载skill时默认绑定当前真实会话;用户明确要求专门入口才另建,并将其设为默认。用宿主受支持工具确认真实ID,建立项目归属与看板映射。不要把内部执行器thread和桌面会话混为一谈。
执行器使用既有模型登录。集群未认证时让本机运行worker和mirror,服务/指标留在集群;模型凭据不离开本机。远程API可用 `control.transport="ssh"`:配置入口账号、独立私钥、`remote_client` 与 `remote_config`。客户端使用严格主机校验,在服务端内存读取服务令牌;不把令牌或模型认证拷进前端。
@@ -81,7 +91,7 @@ source+event_id+status持久幂等,相同故障重复不打扰;恢复必须
GET /api/state的decisions保存卡片与响应。POST /api/decisions登记固定id/title/question及impact/priority/details/recommendation/options/deadline/requires_authorization/task_id;同ID相同规范正文幂等,不同内容冲突。options是{id,label,description}数组,不指定真实thread或任意命令。
POST /api/decisions/<id>/respond提交{option_id,comment,idempotency_key}。有选项须选择合法项,无选项至少写意见;第一次提交原子保存,同key同正文返回原响应,冲突重用或其他提交拒绝。普通状态为decided,权限相关为pending_verification;响应含authorization:false,不能作为提权批准。GET /api/decision-notifications提供最早100条待投递,POST /api/decision-notifications/ack以notification_id幂等确认。
POST /api/decisions/<id>/respond提交{expected_revision,option_id|null,comment,idempotency_key},允许选择合法方案或仅填写非空意见,至少一项。仅open/needs_reconsideration接受提交,保存内容及选项快照,状态统一pending_review;同key/body/revision幂等,不同返回409。旧decided/pending_verification且有response映射pending_review,不能伪造已接受。响应不授予运维权限。通知及ACK路径继续兼容,新增事件规则见下文。
桥接私有配置decision_notifications:true启用notifier投递到notification_targets.control。保存回执与完整输入哈希,未知投递先对账,不盲重发;投递确认不代表方案执行。通知只携带问题、实际选项与意见,背景仍由总控通过API读取,避免塞满会话。沟通展示使用/api/conversation;后台继续用原始/api/messages做恢复与审计。
@@ -146,3 +156,36 @@ created_at由服务端在新建任务时记录,拒绝客户端输入及更新/
本轮验收包括旧数据默认、创建和更新非法归属、被引用交付降级、报告字段保护;前端纯逻辑覆盖长链、多依赖、无依赖、筛选与汇合门禁。执行负责人以既有持久报告流程上报真实证据,收到落库回执后等待集成;集成负责人另做真实浏览器验证和发布,不能以执行完成代替正式验收。
执行会话可按人类已授权的项目协作范围,使用宿主支持的定向消息就共享接口与交接点相互协调;无需每次抄送副主控。唯一事项负责人把关键决定、版本、影响与交接回执落库;范围或归属冲突才交直属副主控。普通进度只更新状态,不制造互相唤醒链。副主控的判断可由推理模型结合明确规则承担,具体模型、费用与执行权限分别核实;用户仅询问模型能力不构成切换型号或购买服务的授权。
## 决策生命周期接口契约
状态为open/pending_review/accepted/completed/needs_reconsideration。对象增加summary、task_id、revision正整数、session_id/session_thread_id可空、archive_status(none/pending/archived)、review/completion可空、supersedes_id及related_decision_ids。GET /api/decisions/<id>读取当前对象,GET /history返回{history:[版本、提交、检查、完成、绑定、归档事件]},所有版本与提交快照保留。创建支持简介、关联任务及替代来源并持久生成session_required;仅创建真实需求。
PATCH当前对象携expected_revision、reason及允许内容字段,乐观锁成功增版本,禁止覆盖response/submissions/review/binding。影响已提交问题或方案的实质改动保留旧选择并转needs_reconsideration,必须重新确认新版本。POST /review携expected_revision/idempotency_key/outcome(accept或reconsider)/reason/impact/execution_plan,可附authorization_evidence;仅检查当前revision真实pending_review提交,转accepted或needs_reconsideration。授权证据只是记录,须主控核对真实人类消息,不能自动执行。
POST /complete携expected_revision/idempotency_key/conclusion/handoff/evidence可选列表,仅有review的accepted/needs_reconsideration可完成并置archive_status=pending。POST /archive-receipt携thread_id/idempotency_key/receipt,仅completed且review/completion/handoff齐备;先由根调用宿主真实归档,再登记回执。
POST /bind-session携expected_revision/idempotency_key/session_id/thread_id,仅普通控制凭据。会话须已注册role=decision、wp=decision.id,真实thread UUID不复用其他决策、主会话或执行者;仅首次或严格重复绑定,禁止静默换绑。真实存在另由宿主工具验证。GET /consultation返回{messages:[既有conversation projection]},POST携text/client_key仅发送绑定session,不接受替代sid;完成归档后只读。GET /api/decision-bridge-bindings仅控制凭据,返回bindings内decision_id/session_id/thread_id/worktree/status/archive_status;fleet只接已有真实thread,不创建模型会话。
POST /consultation-credential由普通凭据签发专用token,数据库只存hash;该token仅允许本决策GET当前/history/consultation、PATCH内容和POST /facts,其余403,completed后禁写仍可读历史。不得向咨询agent分发普通panel token。POST /facts携idempotency_key/question/context可选,持久去重核实请求;POST /facts/<request_id>/answer由普通凭据提交idempotency_key/answer/evidence可选,写历史并通知绑定咨询thread,回复不是用户批准。
通知保留原GET /api/decision-notifications及ACK;工作流事件用独立持久表避免旧decision_id唯一约束。返回notification_id/target(control、human、decision)/通知创建时不可变decision与event快照(含kind、revision及相关字段),event_key幂等。GET不得重写为最新对象,避免破坏持久输入哈希;已提交/未知发送标记和历史保留。只有fact_answered可target=decision,绑定thread由真实session_thread_id确定。session_required、submitted、fact_requested、archive_required送control;reviewed送human仅简述影响与计划;fact_answered送decision,由notifier按已核实绑定定位。绑定后未发session_required、已答facts、已归档请求不再出队;已实际入宿主队列的旧输入按版本核对,不伪称撤回。普通决策事件不能一律路由control覆盖上述目标。
已有唯一人类入口时,所有主控、副主控、执行者的问题/选择/授权/关键结论定向交入口,不能直接使用用户提问工具绕过;入口理解后直接交主控,不经下层事件队列。独立咨询只限该决策内嵌页面,不成为一般项目沟通入口。真实会话创建、绑定核实和归档由根按既定授权执行。
验收覆盖两种检查分支、版本并发、不可改提交快照、选项变化重确认、关联新决策、有限凭据与任务/会话隔离、归档前置及幂等;真实咨询绑定与往返单独验收。暂无真实事项时仅做隔离测试,保留未验证限制,不造生产事项。
完成与归档前须检查绑定咨询session消息:有queued/claimed/uncertain未完成输入时返回409,保持可交流;completed立即拒绝新咨询POST,历史GET保留。fleet仅在archive_status=archived且本机worker无inflight/pending_completion/needs_reconciliation时停止自有子进程,不终止模型writer。已入队旧通知接收者fresh GET核对revision,过期静默停止,不能由快照直接执行。有限CLI及fleet负责已有绑定的桥接,不自行创建或归档宿主会话。
真实决策独立会话的创建、绑定后签发有限凭据、桥接、事实核实和完成归档步骤见 [独立决策会话接入](decision-sessions.md)。notifier调用决策通知submitting接口后才向宿主队列外发,保留不可变快照与未知结果保护;不能仅清应用队列冒充取消宿主输入。
页面升级与旧草稿:状态同步不会替换已加载的网页代码。服务公布当前前端入口文件,版本变化只提示,不自动整页重载或重发。新版草稿保存机制应在同浏览器、同实例及对应会话/决策范围内恢复输入与重试信息;存储失败或旧页面尚未支持持久保存时明确提示先自行保留内容再重载,不能把复制作为正常持久化方案。旧提交缺expected_revision仍拒绝写入,不猜版本;核对response/history和咨询消息确认落库结果,再由人类入口说明操作。旧版已丢稿无服务证据不得承诺恢复。
## 本地草稿实际存储契约
同源localStorage使用workbench-draft-v1:前缀加JSON数组作用域。沟通为[instance_id, communication, 入口session];决策为[instance_id, decision, decision_id, revision];咨询为[instance_id, consultation, decision_id, session_id或unbound, revision]。不包含token,不上传未提交正文。实例或有效版本尚未就绪时禁发,不猜版本;新浏览器、不同源/实例或清理浏览器数据不保证恢复。重新登录不以token作为草稿身份,因此同浏览器同范围可恢复,并非按用户账号隔离。
每次输入写入,POST前先持久保存attempt幂等信息;失败或结果未知保留,刷新后可由用户明确重试,不自动发送。读取/保存失败显示具体风险并阻止发送,可重试保存;清除失败提示旧稿可能残留,不应重复提交。成功只清对应当前版本草稿,比较已存值防迟到响应删掉随后编辑;咨询成功不清决策选择。只确认接口成功不表示模型已回复或业务验收完成。
当前版本无记录时可读取同作用域最近旧版本草稿,保留旧revision,须用户明确重确认,决策旧选项清除后重新选择/检查意见。已完成决策的残留草稿只读,不自动重交。页面不提供额外清草稿按钮,不因切页、隐藏控件或版本提示删除旧稿;确认成功仍用原有比较清除保护。绑定session变化属于不同范围,不承诺自动跨绑定迁移。
+1
View File
@@ -30,6 +30,7 @@ def main():
roles=['worker','mirror']
if cfg.get('notification_targets'):roles.append('notifier')
if cfg.get('task_report_config'):roles.append('report_relay')
if cfg.get('decision_fleet',{}).get('enabled'):roles.append('decision_fleet')
with session_lock(identity):
try:
while True:
+48
View File
@@ -0,0 +1,48 @@
#!/usr/bin/env python3
"""Consult one decision with its private scoped credential, never execute its plan."""
import argparse
import hashlib
import json
from pathlib import Path
import re
from control import Client
def endpoint(cfg, suffix=''):
decision_id=cfg.get('decision_id')
if not isinstance(decision_id,str) or not re.fullmatch(r'[A-Za-z0-9_.:-]{1,128}',decision_id):
raise ValueError('Invalid bound decision')
return '/api/decisions/'+decision_id+suffix
def execute(cfg,action,payload=None):
client=Client(cfg['control'])
if action=='show':return client.call(endpoint(cfg))
if action=='history':return client.call(endpoint(cfg,'/history'))
if action=='edit':
if not isinstance(payload,dict) or 'expected_revision' not in payload or not payload.get('reason'):
raise ValueError('Edit requires current revision and reason')
return client.call(endpoint(cfg),payload,'PATCH')
if action=='ask':
if not isinstance(payload,dict) or not payload.get('question'):
raise ValueError('A factual question is required')
key=payload.get('idempotency_key') or 'fact-'+hashlib.sha256(
json.dumps(payload,sort_keys=True,ensure_ascii=True).encode()).hexdigest()[:32]
return client.call(endpoint(cfg,'/facts'),{**payload,'idempotency_key':key})
raise ValueError('Unsupported consultation action')
def main():
parser=argparse.ArgumentParser(description=__doc__)
parser.add_argument('--config',required=True)
parser.add_argument('action',choices=['show','history','edit','ask'])
parser.add_argument('--payload-file')
parser.add_argument('--question')
args=parser.parse_args()
cfg=json.loads(Path(args.config).read_text(encoding='utf-8-sig'))
payload=json.loads(Path(args.payload_file).read_text(encoding='utf-8-sig')) if args.payload_file else None
if args.question:payload={'question':args.question}
print(json.dumps(execute(cfg,args.action,payload),ensure_ascii=True))
if __name__=='__main__':main()
+191
View File
@@ -0,0 +1,191 @@
#!/usr/bin/env python3
"""Bridge already bound decision threads; host creation and archive stay explicit."""
import argparse
import hashlib
import json
import os
from pathlib import Path
import re
import subprocess
import sys
import time
from control import Client
from worker import atomic_json,session_lock
def busy(path):
if not path.exists():return False
state=json.loads(path.read_text(encoding='utf-8'))
return bool(state.get('inflight') or state.get('pending_completion') or state.get('needs_reconciliation'))
def reconcile_completed(path,client,session_id,thread_id):
"""Clear only a proven terminal original execution, never submit another input."""
state=json.loads(path.read_text(encoding='utf-8'))
record=state.get('inflight') or {}
proof=record.get('submission') or {}
if not record.get('message_id') or not proof.get('input_sha256'):return False
from urllib.parse import quote
rows=client.call('/api/messages?session_id='+quote(session_id,safe=''))['messages']
original=next((m for m in rows if m['id']==record['message_id']),None)
if not original:return False
reply=next((m for m in rows if m['id']==original.get('response_id')),None)
remote=original.get('submission') or {}
if (not reply or original.get('status') not in ('completed','failed')
or remote.get('thread_id')!=thread_id
or remote.get('input_sha256')!=proof['input_sha256']
or (proof.get('turn_id') and remote.get('turn_id')!=proof['turn_id'])):return False
state.setdefault('delivery_receipts',{})[record['message_id']]=remote
for key in ('inflight','pending_completion','needs_reconciliation'):state.pop(key,None)
atomic_json(path,state)
return True
def child_config(base,binding,root):
did=binding['decision_id'];sid=binding['session_id'];thread=binding['thread_id']
if any(not isinstance(v,str) or not re.fullmatch(r'[A-Za-z0-9_.:-]{1,128}',v) for v in (did,sid)):
raise ValueError('Invalid decision binding')
if not re.fullmatch(r'[0-9a-fA-F-]{36}',thread):raise ValueError('Invalid real thread identity')
cwd=Path(binding['worktree']).expanduser().resolve()
if not cwd.is_dir():raise ValueError('Bound thread directory unavailable')
runtime=root/hashlib.sha256(did.encode()).hexdigest()[:24]
runtime.mkdir(parents=True,exist_ok=True,mode=0o700)
cfg={key:base[key] for key in ('control','codex') if key in base}
cfg.update(mode='desktop_queue',session_id=sid,thread_id=thread,cwd=str(cwd),
worker_id='decision-'+hashlib.sha256(sid.encode()).hexdigest()[:20],
state_file=str(runtime/'worker.json'),mirror_state_file=str(runtime/'mirror.json'),
include_progress_snapshot=False,poll_seconds=5,mirror_seconds=5,
max_turn_seconds=base.get('max_turn_seconds',600))
cfg['instructions']=('你是独立决策咨询会话,仅维护决策 '+did+'。只可通过初始化时提供的本决策有限凭据读取历史、解释或修订该决策、向主控提出事实核实请求。'
'不得修改项目代码、系统、其他任务或决策,不执行方案、接受用户提交、伪造检查或归档。需要主控事实时使用本决策facts接口并保留关联ID,不重复催问。'
'用户提交或主控接受不表示新增授权。一般项目问题与待授权事项定向交项目agent对话入口,不另起一般人类沟通。当前网页消息只用于本决策咨询。')
return cfg,runtime
class Fleet:
def __init__(self,cfg):
self.cfg=cfg
settings=cfg['decision_fleet']
self.root=Path(settings['runtime_root']).expanduser().resolve()
self.root.mkdir(parents=True,exist_ok=True,mode=0o700)
self.limit=settings.get('max_active',3)
if isinstance(self.limit,bool) or not isinstance(self.limit,int) or not 1<=self.limit<=3:
raise ValueError('Decision bridge bound must be between one and three')
self.children={}
self.health=Path(cfg['state_file']).parent/'decision_fleet-health.json'
def stop(self,did,force=False):
child=self.children[did]
# Single-cycle children exit naturally; never interrupt a native writer.
if any(p.poll() is None for p in child['processes'].values()):return False
for stream in child['logs'].values():stream.close()
del self.children[did]
return True
def tick(self,bindings):
now=time.time();problems=[];live={};threads=set();sessions=set()
journal_path=self.root/'schedule.json'
journal=json.loads(journal_path.read_text(encoding='utf-8')) if journal_path.exists() else {}
notifications={}
if self.cfg.get('notification_state_file'):
notification_path=Path(self.cfg['notification_state_file'])
if notification_path.exists():notifications=json.loads(notification_path.read_text(encoding='utf-8')).get('deliveries',{})
for binding in bindings:
did=binding['decision_id']
if did in live or binding['thread_id'] in threads or binding['session_id'] in sessions:
raise ValueError('Duplicate decision, session or thread binding')
live[did]=binding;threads.add(binding['thread_id']);sessions.add(binding['session_id'])
for did in list(self.children):
binding=live.get(did)
child=self.children[did]
mirror=child['processes'].get('mirror')
if mirror and mirror.poll()==0:
journal.setdefault(did,{}).setdefault('fact_synced',{}).update(child.get('terminal_facts',{}))
if binding and child_config(self.cfg,binding,self.root)[0]!=self.children[did]['cfg']:
problems.append('binding_changed:'+did);continue
if not self.stop(did) and (not binding or binding.get('archive_status')=='archived'):
problems.append('archive_requires_reconciliation:'+did)
candidates=[]
for did,binding in live.items():
if binding.get('archive_status')=='archived':continue
candidate,runtime=child_config(self.cfg,binding,self.root)
demand=binding.get('demand')
state_path=Path(candidate['state_file'])
local_busy=busy(state_path)
worker=self.children.get(did,{}).get('processes',{}).get('worker')
worker_alive=worker is not None and worker.poll() is None
if local_busy and not worker_alive and demand is not None and not demand.get('uncertain',0) and not demand.get('inflight',0):
try:
if reconcile_completed(state_path,Client(self.cfg['control']),binding['session_id'],binding['thread_id']):local_busy=False
except Exception:pass
if demand is None:
problems.append('queue_summary_unavailable:'+did);demand={}
uncertain=bool(demand.get('uncertain',0) or local_busy)
facts={key:r for key,r in notifications.items() if r.get('decision_id')==did and r.get('event_kind')=='fact_answered'}
terminal_facts={key:str(r.get('completed_at') or r.get('turn_id') or 'done') for key,r in facts.items() if r.get('processing_done')}
synced=journal.get(did,{}).get('fact_synced',{})
fact_demand=any(not r.get('processing_done') for r in facts.values()) or any(synced.get(key)!=value for key,value in terminal_facts.items())
needed=bool(demand.get('queued',0) or demand.get('inflight',0) or uncertain or fact_demand)
if not needed:
if did in journal:journal[did].pop('waiting_since',None)
continue
record=journal.setdefault(did,{})
record.setdefault('waiting_since',min(now,demand.get('oldest_queued_at') or now))
if did in self.children:
if uncertain and not worker_alive:problems.append('execution_requires_reconciliation:'+did)
continue
# Finite human boost: old ordinary work eventually precedes new human work.
score=now-record['waiting_since']+(60 if demand.get('human_queued',0) else 0)
candidates.append((-score,record['waiting_since'],record.get('last_served',0),did,binding,candidate,runtime,uncertain,terminal_facts))
candidates.sort(key=lambda row:row[:4]);waiting=0
for _,_,_,did,binding,candidate,runtime,uncertain,terminal_facts in candidates:
if len(self.children)>=self.limit:waiting+=1;continue
config_path=runtime/'bridge.json'
if config_path.exists() and json.loads(config_path.read_text(encoding='utf-8'))!=candidate:
problems.append('saved_binding_changed:'+did);continue
atomic_json(config_path,candidate)
child={'cfg':candidate,'runtime':runtime,'path':config_path,'processes':{},'logs':{},'terminal_facts':terminal_facts}
self.children[did]=child
journal[did].update(waiting_since=now,last_served=now)
atomic_json(journal_path,journal)
roles=('mirror',) if uncertain or binding.get('demand',{}).get('inflight',0) or not binding.get('demand',{}).get('queued',0) else ('worker','mirror')
if uncertain:problems.append('execution_requires_reconciliation:'+did)
for role in roles:
stream=open(runtime/(role+'.log'),'a',encoding='utf-8');child['logs'][role]=stream
command=[sys.executable,'-X','utf8',str(Path(__file__).with_name(role+'.py')),'--config',str(config_path),'--once']
child['processes'][role]=subprocess.Popen(command,stdout=stream,stderr=stream,
**({'creationflags':subprocess.CREATE_NO_WINDOW} if os.name=='nt' else {}))
atomic_json(journal_path,journal)
snapshot={'status':'failed' if problems else 'ok','updated':now,'active':len(self.children),
'waiting':waiting,'problems':problems,'bindings':{did:{'session_id':c['cfg']['session_id'],
'thread_id':c['cfg']['thread_id'],'processes':{r:{'pid':p.pid,'running':p.poll() is None}
for r,p in c['processes'].items()}} for did,c in self.children.items()}}
atomic_json(self.health,snapshot)
return snapshot
def close(self):
# Active cycles retain their durable state and host writer locks.
for did in list(self.children):
for stream in self.children[did]['logs'].values():stream.close()
self.stop(did)
def main():
parser=argparse.ArgumentParser(description=__doc__);parser.add_argument('--config',required=True)
parser.add_argument('--once',action='store_true');args=parser.parse_args()
cfg=json.loads(Path(args.config).read_text(encoding='utf-8-sig'));fleet=Fleet(cfg)
if os.name=='posix':os.umask(0o077)
client=Client(cfg['control'])
with session_lock('decision-fleet:'+str(fleet.root)):
try:
while True:
try:fleet.tick(client.call('/api/decision-bridge-bindings')['bindings'])
except Exception:
atomic_json(fleet.health,{'status':'failed','updated':time.time(),'reason':'Inspect decision bindings and private bridge state'})
if args.once:raise
if args.once:return
time.sleep(5)
finally:fleet.close()
if __name__=='__main__':main()
+2 -2
View File
@@ -19,7 +19,7 @@ def report_process(cfg,root,role,process,records,started_at=None):
health=data.get('health',data)
healthy=health.get('status')=='ok' and time.time()-health.get('updated',0)<60
except (OSError,ValueError):healthy=False
if code is None and role in ('notifier','report_relay') and not healthy and not record and started_at is not None and time.time()-started_at>30:
if code is None and role in ('notifier','report_relay','decision_fleet') and not healthy and not record and started_at is not None and time.time()-started_at>30:
record={'event_id':str(uuid.uuid4()),'state':'firing','pending':'firing','first_seen':time.time(),'severity':'warning'}
records[role]=record
if record and record.get('pending')=='resolved' and not (code is None and healthy):
@@ -54,7 +54,7 @@ def report_process(cfg,root,role,process,records,started_at=None):
try:
Client(cfg['control']).call('/api/hooks',{
'event_id':record['event_id'],'source':'bridge-'+role,'severity':record.get('severity','warning'),
'status':record['pending'],'summary':{'worker':'消息转发暂时中断','mirror':'聊天同步暂时中断','notifier':'事件通知暂时中断','report_relay':'完成上报暂时中断'}.get(role,'本机桥接暂时中断'),
'status':record['pending'],'summary':{'worker':'消息转发暂时中断','mirror':'聊天同步暂时中断','notifier':'事件通知暂时中断','report_relay':'完成上报暂时中断','decision_fleet':'决策咨询桥接暂时中断'}.get(role,'本机桥接暂时中断'),
'impact':'网页收发或历史同步可能延迟',
'evidence':['Private executor log: '+role+'.log'],
'action':'已启用有界重连;结果未知的模型输入不重复执行',
+69 -4
View File
@@ -13,6 +13,32 @@ from worker import atomic_json,session_lock
def notification_text(n):
if 'decision' in n and n.get('event'):
d=n['decision'];event=n['event'];kind=event.get('kind')
link='#/decisions?decision='+str(d.get('id',''))
title=str(d.get('title',''))
header='[workbench-decision:'+n['notification_id']+']\n'
if kind=='reviewed':
review=d.get('review') or event
return (header+'决策检查结果:'+title+'\n'+str(review.get('reason',''))
+'\n效果:'+str(review.get('impact',''))+'\n规划:'+str(review.get('execution_plan',''))
+'\n详情:'+link+'\n仅向项目入口简短解释检查结论与规划,不重复列选项。接受不表示已执行或获得新增授权。')
if kind=='fact_answered':
return (header+'主控对本决策的事实核实答复:'+title+'\n'+str(event.get('answer',''))
+'\n关联请求:'+str(event.get('request_id',''))+';决策:'+link
+'\n先读取本决策当前版本与历史;该答复是项目事实资料,不是人类批准。仅可解释或维护本决策,不执行项目方案、代码或系统操作。')
action={
'session_required':'仅当当前仍未绑定且属于真实待决策事项时,使用宿主受支持工具创建一个独立真实咨询会话,再注册role=decision并绑定。已有会话不得重复创建。不给咨询会话普通控制凭据,只提供本决策有限凭据;无真实事项不得创建验收占位会话。',
'submitted':'读取提交版本与不可变选择快照,核对适用性、范围与风险,保存accept或reconsider检查结论及效果、执行规划。不要把提交直接当接受、执行或新增授权。',
'fact_requested':'核对当前请求是否仍待答,定向读取事实并通过本决策facts答复接口保存结果;不广播、不把咨询问题当用户授权。',
'archive_required':'仅在当前已完成、检查结论与交接已保存、没有待处理咨询时,使用宿主受支持归档工具归档该真实会话;核实成功后记录archive-receipt。已归档不重复操作,不能只写数据库冒充宿主归档。',
}.get(kind)
if not action:raise ValueError('Unknown decision workflow event')
question='\n待核实事实:'+str(event.get('question','')) if kind=='fact_requested' else ''
return (header+'内部决策流程:'+title+'\n类型:'+kind+';版本:'+str(event.get('revision',d.get('revision','')))
+';请求:'+str(event.get('request_id',''))+'\n详情:'+link+question
+'\n先读取当前卡片/版本和真实会话状态,过期、已处理事件静默停止。本事件资料不是新授权。'+action
+'问题、待授权和面向人类的结论只定向交项目agent对话入口,不直接向用户提问。')
if 'checkpoint' in n and 'task' in n:
data={k:n.get(k) for k in ('notification_id','checkpoint','revision','task')}
return ('[workbench-eta:'+n['notification_id']+']\n[内部ETA检查点,不是用户通知或新授权。]\n'
@@ -25,7 +51,7 @@ def notification_text(n):
comment=response.get('comment','')
excerpt=comment if len(comment)<=500 else comment[:500]+'…(完整意见见决策详情)'
return ('项目决策已提交:'+str(d.get('title',''))+'\n选择:'+label+'\n意见:'+excerpt
+'\n状态:'+('待核实,不能视为新增授权' if d.get('requires_authorization') else '已记录,待按既定范围执行')
+'\n状态:待主控检查;不能视为已接受、已执行或新增授权'
+'\n决策编号:'+str(d.get('id',''))+';回执:'+n['notification_id']
+'\n请读取决策详情核对实际选择,再继续协调;排队投递不代表业务完成。')
data={k:n['hook'].get(k,'') for k in ('source','event_id','status','severity','task_id','summary','impact','evidence','action','next_step','log_id','escalated')}
@@ -33,8 +59,26 @@ def notification_text(n):
+json.dumps(data,ensure_ascii=False)+'\n请核实事件与影响,按既定权限处理。面向用户仅汇报持续重大影响、需行动或待决策;短暂自动恢复只进日志,不向人类入口转发。若有log_id,给一句摘要并链接日志页#/logs?incident=<log_id>,不复制原载荷;重复状态不打扰。消息已投递不代表故障已修复。')
def target_ready(cfg,records,thread,cache):
if not cfg.get('enforce_backpressure'):
def schedule_notifications(notifications,state,now):
"""Prefer decisions while aging waiting work into FIFO; persist across restarts.
This changes dispatch order only, never authorization, receipt or event identity.
A busy/uncertain target remains blocked regardless of waiting time.
"""
waiting=state.setdefault('notification_waiting',{})
def identity(n):
return ('decision:' if 'decision' in n else 'eta:' if 'checkpoint' in n else 'hook:')+n['notification_id']
for n in notifications:
waiting.setdefault(identity(n),now)
def rank(n):
first=waiting[identity(n)]
priority=0 if 'decision' in n else 1 if n.get('hook',{}).get('severity')=='critical' else 2 if 'hook' in n else 3
return (0 if now-first>=120 else priority+1,first,identity(n))
return sorted(notifications,key=rank)
def target_ready(cfg,records,thread,cache,force_reconcile=False):
if not cfg.get('enforce_backpressure') and not force_reconcile:
return True
limit=cfg.get('max_inflight_per_target',1)
if not isinstance(limit,int) or isinstance(limit,bool) or not 1<=limit<=3:
@@ -70,6 +114,15 @@ def deliver(client,cfg,state,path):
records=state.setdefault('deliveries',{})
errors=[]
cache={}
# Fact answers enter the native consultation thread directly. Reconcile their
# completion even with an empty outbox, so a demand-driven mirror can retire.
for thread in {r['thread_id'] for r in records.values()
if r.get('event_kind')=='fact_answered' and not r.get('processing_done')}:
try:
target_ready(cfg,records,thread,cache,force_reconcile=True)
except Exception:
errors.append('fact_answer_reconciliation_unavailable')
atomic_json(path,state)
if cfg.get('coalesce_stale_hooks'):
# Upgrade old accepted-but-unacked receipts before pruning pending data.
# Unknown submissions are protected, never silently cancelled or replayed.
@@ -102,7 +155,9 @@ def deliver(client,cfg,state,path):
notifications += batch['notifications']
queue_counts[endpoint]=batch.get('pending_count',len(batch['notifications']))
except Exception:errors.append('outbox_unavailable')
notifications.sort(key=lambda n:0 if 'decision' in n else 1 if n.get('hook',{}).get('severity')=='critical' else 2 if 'hook' in n else 3)
notifications=schedule_notifications(notifications,state,time.time())
# Waiting age must survive offline delivery/ACK failures, not just successful sends.
atomic_json(path,state)
task_owners={}
if cfg.get('execution_notification_targets'):
snapshot=client.call('/api/state')
@@ -118,6 +173,11 @@ def deliver(client,cfg,state,path):
key='event:'+event_id if internal_event else ('decision:' if 'decision' in n else 'eta:' if 'checkpoint' in n else '')+n['notification_id']
try:
thread=cfg.get('internal_event_thread_id') if internal_event else cfg.get('eta_review_thread_id') if 'checkpoint' in n and cfg.get('eta_review_thread_id') else cfg['notification_targets'].get(n['target'])
if 'decision' in n and n.get('target')=='decision':
if n.get('event',{}).get('kind')!='fact_answered':raise ValueError('Unsupported consultation notification')
thread=n['decision'].get('session_thread_id')
if not isinstance(thread,str) or not re.fullmatch(r'[0-9a-fA-F-]{36}',thread) or thread in cfg['notification_targets'].values():
raise ValueError('Invalid independent consultation target')
if execution_thread and 'decision' not in n:thread=execution_thread
if not thread:raise ValueError('Missing explicitly configured notification target')
prompt=notification_text({**n,'notification_id':event_id} if internal_event else n)
@@ -127,7 +187,11 @@ def deliver(client,cfg,state,path):
if old and (old['thread_id']!=thread or old['input_sha256']!=digest):raise ValueError('Changed persisted hook identity')
if not old:
if not target_ready(cfg,records,thread,cache):continue
if 'decision' in n:
client.call('/api/decision-notifications/submitting',{'notification_id':n['notification_id']})
old={'kind':'hook' if 'hook' in n else 'decision' if 'decision' in n else 'eta','notification_ids':([item['notification_id'] for item in notifications if item.get('hook')==n.get('hook')] if internal_event else [n['notification_id']]),'created_at':time.time(),'thread_id':thread,'input_sha256':digest,'state':'submitting'}
if 'decision' in n:
old.update(decision_id=n['decision']['id'],event_kind=n.get('event',{}).get('kind'))
records[key]=old
atomic_json(path,state)
if 'hook' in n and cfg.get('coalesce_stale_hooks'):
@@ -144,6 +208,7 @@ def deliver(client,cfg,state,path):
# Crash after queue acceptance: reconcile exact actual input, never requeue.
with AppServer(cfg['codex']) as reader:
meta,turns=reader.history(thread)
if meta.get('id')!=thread:raise ValueError('Unexpected reconciliation thread identity')
observed=next((t['id'] for t in turns if any(
i.get('type')=='userMessage' and '\n'.join(p.get('text','') for p in i.get('content',[]) if p.get('type')=='text')==prompt
for i in t.get('items',[]))),None)
+1 -1
View File
@@ -95,7 +95,7 @@ class AttentionTests(unittest.TestCase):
auto=state['items'][0]
self.assertEqual(auto['href'],'/decisions?decision=d')
self.store.attention(item(decision_id='d'))
self.store.decision_respond('d',dict(option_id=None,comment='Chosen',idempotency_key='reply'))
self.store.decision_respond('d',dict(option_id=None,comment='Chosen',idempotency_key='reply',expected_revision=1))
state=self.store.state()['attention']
self.assertEqual(state['items'],[])
self.assertFalse(any(state['pages'].values()))
+102
View File
@@ -0,0 +1,102 @@
"""Decision bridge boundaries without spawning a model or modifying host sessions."""
import json
from pathlib import Path
import sys
import tempfile
import unittest
from unittest.mock import patch
sys.path.insert(0,str(Path(__file__).resolve().parents[1]/'scripts'))
import decision
import decision_fleet
from worker import atomic_json
class Process:
pid=42
code=None
def poll(self):return self.code
def terminate(self):self.code=0
def wait(self,timeout=None):return self.code
def kill(self):self.code=-1
class DecisionBridgeTests(unittest.TestCase):
def fixture(self,root):
cfg={'control':{},'codex':'codex','state_file':str(Path(root)/'worker.json'),
'decision_fleet':{'runtime_root':str(Path(root)/'decisions'),'enabled':True,'max_active':1}}
binding={'decision_id':'d','session_id':'s','thread_id':'11111111-1111-4111-8111-111111111111',
'worktree':root,'status':'open','archive_status':'none',
'demand':{'queued':1,'human_queued':1,'inflight':0,'uncertain':0}}
return cfg,binding
def test_only_bound_threads_and_bounded_startup_are_bridged(self):
with tempfile.TemporaryDirectory() as root:
cfg,binding=self.fixture(root);fleet=decision_fleet.Fleet(cfg)
second={**binding,'decision_id':'other','session_id':'other','thread_id':'22222222-2222-4222-8222-222222222222'}
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
status=fleet.tick([binding,second]);fleet.tick([binding,second])
self.assertEqual(spawn.call_count,2)
self.assertEqual(status['waiting'],1)
self.assertEqual(status['active'],1)
self.assertTrue(all('app-server' not in call.args[0] for call in spawn.call_args_list))
self.assertEqual(fleet.children['d']['cfg']['thread_id'],binding['thread_id'])
self.assertNotIn('notification_targets',fleet.children['d']['cfg'])
fleet.close()
def test_binding_change_and_duplicate_target_never_redirect_running_work(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.fixture(root);fleet=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
fleet.tick([b]);old=fleet.children['d']['cfg']['thread_id']
result=fleet.tick([{**b,'thread_id':'22222222-2222-4222-8222-222222222222'}])
self.assertEqual(result['status'],'failed')
self.assertEqual(spawn.call_count,2)
self.assertEqual(fleet.children['d']['cfg']['thread_id'],old)
with self.assertRaises(ValueError):fleet.tick([b,{**b,'decision_id':'other'}])
fleet.close()
def test_archive_waits_for_pending_completion_and_does_not_kill_model(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.fixture(root);fleet=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()):
fleet.tick([b]);child=fleet.children['d'];state=Path(child['cfg']['state_file'])
atomic_json(state,{'inflight':{'message_id':'message'}})
result=fleet.tick([{**b,'status':'completed','archive_status':'archived'}])
self.assertEqual(result['status'],'failed')
self.assertIn('d',fleet.children)
self.assertTrue(all(p.poll() is None for p in child['processes'].values()))
atomic_json(state,{})
for process in child['processes'].values():process.code=0
fleet.tick([{**b,'status':'completed','archive_status':'archived'}])
self.assertEqual(fleet.children,{})
self.assertTrue(state.exists())
def test_unknown_inflight_is_never_restarted(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.fixture(root);fleet=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
fleet.tick([b]);child=fleet.children['d']
atomic_json(Path(child['cfg']['state_file']),{'needs_reconciliation':True})
child['processes']['worker'].code=1
self.assertEqual(fleet.tick([b])['status'],'failed')
self.assertEqual(spawn.call_count,2)
fleet.close()
def test_consultation_helper_cannot_choose_other_decision_or_review(self):
calls=[]
class Client:
def __init__(self,*args):pass
def call(self,*args):calls.append(args);return {}
cfg={'control':{},'decision_id':'decision-one'}
with patch.object(decision,'Client',Client):
decision.execute(cfg,'show')
decision.execute(cfg,'ask',{'question':'What is the dependency?'})
decision.execute(cfg,'ask',{'question':'What is the dependency?'})
self.assertEqual(calls[1][1]['idempotency_key'],calls[2][1]['idempotency_key'])
self.assertEqual(calls[0][0],'/api/decisions/decision-one')
with self.assertRaises(ValueError):decision.execute(cfg,'review',{})
with self.assertRaises(ValueError):decision.execute({'control':{},'decision_id':'../other'},'show')
with self.assertRaises(ValueError):decision.execute(cfg,'edit',{'title':'No revision'})
if __name__=='__main__':unittest.main()
+76
View File
@@ -0,0 +1,76 @@
import json
from pathlib import Path
import sys
import tempfile
import unittest
from unittest.mock import patch
sys.path.insert(0,str(Path(__file__).resolve().parents[1]/'scripts'))
import decision_fleet
from test_decision_bridge import Process
import test_decision_bridge
class DemandTests(unittest.TestCase):
def setup_fleet(self,root):return test_decision_bridge.DecisionBridgeTests().fixture(root)
def test_idle_bindings_start_nothing(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.setup_fleet(root);b['demand']['queued']=0
f=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen') as spawn:
self.assertEqual(f.tick([b])['active'],0);spawn.assert_not_called()
def test_one_message_cycle_releases_and_old_waiter_wins(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.setup_fleet(root);f=decision_fleet.Fleet(cfg)
other={**b,'decision_id':'z','session_id':'z','thread_id':'22222222-2222-4222-8222-222222222222'}
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
with patch.object(decision_fleet.time,'time',return_value=100):f.tick([b,other])
self.assertIn('--once',spawn.call_args.args[0])
for p in f.children['d']['processes'].values():p.code=0
with patch.object(decision_fleet.time,'time',return_value=110):f.tick([b,other])
self.assertEqual(set(f.children),{'z'});f.close()
def test_old_ordinary_precedes_fresh_human_after_restart(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.setup_fleet(root);b['demand']={**b['demand'],'human_queued':0,'oldest_queued_at':1}
f=decision_fleet.Fleet(cfg)
other={**b,'decision_id':'a','session_id':'a','thread_id':'22222222-2222-4222-8222-222222222222','demand':{'queued':1,'human_queued':1}}
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()):
with patch.object(decision_fleet.time,'time',return_value=200):f.tick([b,other])
self.assertEqual(set(f.children),{'d'});f.close()
saved=json.loads((f.root/'schedule.json').read_text());self.assertEqual(saved['a']['waiting_since'],200)
def test_uncertain_after_restart_only_mirrors(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.setup_fleet(root);b['demand']['uncertain']=1
f=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
result=f.tick([b]);self.assertEqual(set(f.children['d']['processes']),{'mirror'})
self.assertEqual(spawn.call_count,1);self.assertEqual(result['status'],'failed');f.close()
def test_fact_reply_waits_for_native_terminal_and_final_mirror(self):
with tempfile.TemporaryDirectory() as root:
cfg,b=self.setup_fleet(root);b['demand']['queued']=0
cfg['notification_state_file']=str(Path(root)/'notifier.json')
path=Path(cfg['notification_state_file'])
record={'decision_id':'d','event_kind':'fact_answered','processing_done':False}
decision_fleet.atomic_json(path,{'deliveries':{'receipt':record}})
f=decision_fleet.Fleet(cfg)
with patch.object(decision_fleet.subprocess,'Popen',side_effect=lambda *a,**k:Process()) as spawn:
f.tick([b]);self.assertEqual(set(f.children['d']['processes']),{'mirror'})
f.children['d']['processes']['mirror'].code=0
record.update(processing_done=True,completed_at=123)
decision_fleet.atomic_json(path,{'deliveries':{'receipt':record}})
f.tick([b]);self.assertEqual(spawn.call_count,2)
f.children['d']['processes']['mirror'].code=0
self.assertEqual(f.tick([b])['active'],0)
self.assertEqual(f.tick([b])['active'],0);self.assertEqual(spawn.call_count,2)
f.close()
def test_terminal_proof_clears_local_without_replaying(self):
with tempfile.TemporaryDirectory() as root:
path=Path(root)/'state.json';proof={'thread_id':'t','input_sha256':'h','turn_id':'turn'}
decision_fleet.atomic_json(path,{'inflight':{'message_id':'original','submission':proof},'needs_reconciliation':True})
class Client:
def call(self,*args):return {'messages':[{'id':'original','status':'completed','response_id':'reply','submission':proof},{'id':'reply','text':'done'}]}
self.assertFalse(decision_fleet.reconcile_completed(path,Client(),'s','different-thread'))
self.assertTrue(decision_fleet.busy(path))
self.assertTrue(decision_fleet.reconcile_completed(path,Client(),'s','t'))
self.assertFalse(decision_fleet.busy(path));self.assertIn('original',json.loads(path.read_text())['delivery_receipts'])
if __name__=='__main__':unittest.main()
+304
View File
@@ -0,0 +1,304 @@
"""Decision lifecycle contract tests use isolated stores and HTTP servers only."""
import concurrent.futures
import hashlib
import json
import sqlite3
from pathlib import Path
import tempfile
import unittest
from agent_control.store import Store, Invalid, Conflict
import test_decisions as fixtures
from test_decisions import definition, answer
THREAD='00000000-0000-4000-8000-000000000001'
def review(**changes):
data=dict(expected_revision=1,idempotency_key='review',outcome='accept',reason='Checked facts',impact='Limited scope',execution_plan='Owner verifies execution separately')
data.update(changes)
return data
def completion(**changes):
data=dict(expected_revision=1,idempotency_key='complete',conclusion='Reviewed outcome',handoff='Owner retains implementation task',evidence=['Synthetic verification'])
data.update(changes)
return data
def bind(store,did='choice',sid='consult',thread=THREAD):
store.session(dict(id=sid,name='Consultation',role='decision',wp=did,thread_id=thread,worktree='/synthetic'))
return store.decision_bind(did,dict(expected_revision=1,idempotency_key='bind',session_id=sid,thread_id=thread))
class WorkflowTests(unittest.TestCase):
def setUp(self):
self.tmp=tempfile.TemporaryDirectory()
self.path=Path(self.tmp.name)/'state.sqlite3'
self.store=Store(self.path)
self.store.decision(definition())
def tearDown(self):
self.tmp.cleanup()
def test_accept_complete_archive_requires_review_and_real_receipt(self):
bind(self.store)
with self.assertRaises(Conflict): self.store.decision_complete('choice',completion())
with self.assertRaises(Conflict): self.store.decision_review('choice',review())
self.store.decision_respond('choice',answer())
accepted=self.store.decision_review('choice',review())
self.assertEqual(accepted['status'],'accepted')
self.assertFalse(accepted['response']['authorization'])
self.assertEqual(accepted,self.store.decision_review('choice',review()))
completed=self.store.decision_complete('choice',completion())
self.assertEqual((completed['status'],completed['archive_status']),('completed','pending'))
receipt=dict(thread_id=THREAD,idempotency_key='archive',receipt='Host tool receipt synthetic')
with self.assertRaises(Conflict): self.store.decision_archive('choice',dict(receipt,thread_id='other'))
archived=self.store.decision_archive('choice',receipt)
self.assertEqual(archived['archive_status'],'archived')
self.assertEqual(archived,Store(self.path).decision_archive('choice',receipt))
with self.assertRaises(Conflict): self.store.decision_archive('choice',dict(receipt,receipt='changed'))
kinds=[x['kind'] for x in self.store.decision_history('choice')['history']]
self.assertEqual(kinds,['version','binding','submission','review','completion','archive'])
def test_reconsider_and_free_text_with_options(self):
bind(self.store)
submitted=self.store.decision_respond('choice',answer(option_id=None,comment='Alternative approach'))
self.assertEqual(submitted['status'],'pending_review')
reconsidered=self.store.decision_review('choice',review(outcome='reconsider'))
self.assertEqual(reconsidered['status'],'needs_reconsideration')
self.assertEqual(self.store.decision_complete('choice',completion())['status'],'completed')
with self.assertRaises(Conflict): self.store.decision_respond('choice',answer(idempotency_key='again'))
def test_complete_without_bound_session_cannot_request_archive(self):
self.store.decision_respond('choice',answer())
self.store.decision_review('choice',review())
with self.assertRaises(Conflict): self.store.decision_complete('choice',completion())
self.assertEqual(self.store.decision_get('choice')['status'],'accepted')
self.assertFalse(any(n['event']['kind']=='archive_required' for n in self.store.decision_notifications()['notifications']))
def test_versions_preserve_submission_and_original_create_definition(self):
submitted=self.store.decision_respond('choice',answer())
value=self.store.decision_patch('choice',dict(expected_revision=1,reason='New facts',options=[dict(id='b',label='B',description='Different')]))
self.assertEqual((value['revision'],value['status']),(2,'needs_reconsideration'))
self.assertEqual(value['response'],submitted['response'])
self.assertEqual(value['response']['snapshot']['options'][0]['id'],'a')
self.assertEqual(self.store.decision(definition()),value)
with self.assertRaises(Conflict): self.store.decision_review('choice',review(expected_revision=2))
with self.assertRaises(Conflict): self.store.decision_respond('choice',answer(idempotency_key='new'))
with self.assertRaises(Invalid): self.store.decision_respond('choice',answer(expected_revision=2,idempotency_key='new'))
fresh=self.store.decision_respond('choice',answer(expected_revision=2,option_id='b',idempotency_key='new'))
self.assertEqual(fresh['response']['revision'],2)
history=self.store.decision_history('choice')['history']
self.assertEqual(len([e for e in history if e['kind']=='submission']),2)
self.assertEqual(history[1]['data']['snapshot']['options'][0]['id'],'a')
def test_reconsideration_attention_tracks_status_without_losing_response(self):
self.assertTrue(self.store.state()['attention']['pages']['decisions'])
first=self.store.decision_respond('choice',answer())
self.assertFalse(self.store.state()['attention']['pages']['decisions'])
value=self.store.decision_review('choice',review(outcome='reconsider'))
self.assertEqual(value['response'],first['response'])
self.assertTrue(self.store.state()['attention']['pages']['decisions'])
self.store.decision_respond('choice',answer(idempotency_key='again'))
self.assertFalse(self.store.state()['attention']['pages']['decisions'])
value=self.store.decision_patch('choice',dict(expected_revision=1,reason='Material new facts',question='New question?'))
self.assertIsNotNone(value['response'])
self.assertTrue(self.store.state()['attention']['pages']['decisions'])
self.store.decision_respond('choice',answer(expected_revision=2,idempotency_key='new-revision'))
self.assertFalse(self.store.state()['attention']['pages']['decisions'])
def test_concurrent_patch_has_single_winner(self):
def patch(index):
try: return self.store.decision_patch('choice',dict(expected_revision=1,reason='Evidence',question='Q'+str(index)))
except Conflict: return None
with concurrent.futures.ThreadPoolExecutor(max_workers=6) as pool:
results=list(pool.map(patch,range(12)))
self.assertEqual(sum(r is not None for r in results),1)
self.assertEqual(self.store.decision_get('choice')['revision'],2)
for bad in [True,0,'2',None]:
with self.assertRaises(Invalid): self.store.decision_patch('choice',dict(expected_revision=bad,reason='why',title='new'))
with self.assertRaises(Invalid): self.store.decision_patch('choice',dict(expected_revision=2,reason='why',response={}))
def test_related_decisions_are_explicit_and_tasks_validated(self):
with self.assertRaises(Invalid): self.store.decision(definition(id='bad',supersedes_id='bad'))
with self.assertRaises(Invalid): self.store.decision(definition(id='bad',supersedes_id='missing'))
child=self.store.decision(definition(id='next',supersedes_id='choice',summary='Follow up'))
self.assertEqual(child['related_decision_ids'],['choice'])
self.assertEqual(self.store.decision_get('choice')['related_decision_ids'],['next'])
with self.assertRaises(Invalid): self.store.decision_patch('choice',dict(expected_revision=1,reason='why',task_id='missing'))
self.assertEqual(len(self.store.state()['decisions']),2)
def test_bind_isolation_and_identity_is_immutable(self):
with self.assertRaises(Conflict): self.store.decision_consultation('choice')
self.store.session(dict(id='worker',name='Executor',thread_id=THREAD))
self.store.session(dict(id='consult',name='Consult',role='decision',wp='choice',thread_id=THREAD))
data=dict(expected_revision=1,idempotency_key='bind',session_id='consult',thread_id=THREAD)
with self.assertRaises(Conflict): self.store.decision_bind('choice',data)
self.store.session(dict(id='worker',name='Executor',thread_id='00000000-0000-4000-8000-000000000002'))
bound=self.store.decision_bind('choice',data)
self.assertEqual(self.store.decision_bind('choice',data),bound)
with self.assertRaises(Conflict): self.store.decision_bind('choice',dict(data,idempotency_key='other'))
with self.assertRaises(Conflict): self.store.session(dict(id='consult',name='Mutated',role='worker',wp='choice',thread_id=THREAD))
with self.assertRaises(Conflict): self.store.session(dict(id='other',name='Reuse',thread_id=THREAD))
self.assertEqual(self.store.decision_bindings()['bindings'][0]['thread_id'],THREAD)
def test_completion_blocks_pending_inputs_and_consultation_is_readonly_after(self):
bind(self.store)
msg=self.store.decision_consultation('choice',dict(text='Question',client_key='message'))
self.assertEqual(msg,self.store.decision_consultation('choice',dict(text='Question',client_key='message')))
with self.assertRaises(Invalid): self.store.decision_consultation('choice',dict(text='x',client_key='x',session_id='other'))
self.store.decision_respond('choice',answer())
self.store.decision_review('choice',review())
for status in ['queued','claimed','uncertain']:
with self.store.db() as db: db.execute('UPDATE messages SET status=?',(status,))
with self.assertRaises(Conflict): self.store.decision_complete('choice',completion())
with self.store.db() as db: db.execute("UPDATE messages SET status='completed'")
self.store.decision_complete('choice',completion())
with self.assertRaises(Conflict): self.store.decision_consultation('choice',dict(text='Late',client_key='late'))
with self.assertRaises(Conflict): self.store.send(dict(session_id='consult',text='Late',idempotency_key='late'))
self.assertTrue(self.store.decision_consultation('choice')['messages'])
with self.store.db() as db: db.execute("UPDATE messages SET status='uncertain'")
with self.assertRaises(Conflict): self.store.decision_archive('choice',dict(thread_id=THREAD,idempotency_key='archive',receipt='receipt'))
def test_consultation_send_and_completion_are_atomic(self):
bind(self.store)
self.store.decision_respond('choice',answer())
self.store.decision_review('choice',review())
def run(action):
try:
if action=='send':
return action,self.store.decision_consultation('choice',dict(text='Concurrent input',client_key='race'))
return action,self.store.decision_complete('choice',completion())
except Conflict:
return action,None
with concurrent.futures.ThreadPoolExecutor(max_workers=2) as pool:
outcomes=dict(pool.map(run,['send','complete']))
self.assertEqual(sum(v is not None for v in outcomes.values()),1)
if outcomes['send'] is not None:
self.assertEqual(self.store.decision_get('choice')['status'],'accepted')
else:
self.assertEqual(self.store.decision_get('choice')['status'],'completed')
self.assertEqual(self.store.messages('consult'),[])
def test_notification_snapshots_and_cancel_only_unsent(self):
notice=self.store.decision_notifications()['notifications'][0]
self.store.decision_submitting(dict(notification_id=notice['notification_id']))
bind(self.store)
self.assertEqual(self.store.decision_notifications()['notifications'][0],notice)
self.store.decision_respond('choice',answer())
submitted=next(n for n in self.store.decision_notifications()['notifications'] if n['event']['kind']=='submitted')
self.store.decision_submitting(dict(notification_id=submitted['notification_id']))
self.store.decision_patch('choice',dict(expected_revision=1,reason='Change',question='New?'))
self.assertIn(submitted,self.store.decision_notifications()['notifications'])
self.assertEqual(submitted['event']['revision'],1)
self.assertEqual(submitted['decision']['question'],'Which approach?')
def test_fact_requests_dedup_answer_isolation_and_notification(self):
bind(self.store)
request=dict(idempotency_key='facts',question='Which version?',context='Need evidence')
fact=self.store.decision_fact('choice',request)
self.assertEqual(fact,Store(self.path).decision_fact('choice',request))
self.store.decision(definition(id='other'))
with self.assertRaises(Invalid): self.store.decision_fact_answer('other',fact['id'],dict(idempotency_key='answer',answer='x'))
body=dict(idempotency_key='answer',answer='Verified version',evidence=['fixture'])
result=self.store.decision_fact_answer('choice',fact['id'],body)
self.assertEqual(result,self.store.decision_fact_answer('choice',fact['id'],body))
notices=self.store.decision_notifications()['notifications']
self.assertFalse(any(n['event']['kind']=='fact_requested' for n in notices))
notice=next(n for n in notices if n['event']['kind']=='fact_answered')
self.assertEqual((notice['target'],notice['decision']['session_thread_id']),('decision',THREAD))
self.assertEqual(self.store.decision_get('choice')['status'],'open')
self.assertFalse(any(e['kind']=='review' for e in self.store.decision_history('choice')['history']))
def test_queue_health_reads_workflow_outbox_and_submission_markers(self):
initial=self.store.queue_health()['decisions']
self.assertEqual(initial['pending_count'],1)
self.assertIsNotNone(initial['oldest_pending_at'])
nid=self.store.decision_notifications()['notifications'][0]['notification_id']
self.store.decision_submitting(dict(notification_id=nid))
self.assertEqual(self.store.queue_health()['decisions']['submission_started_unconfirmed_count'],1)
self.store.decision_ack(dict(notification_id=nid))
self.assertEqual(self.store.queue_health()['decisions']['pending_count'],0)
self.store.decision_respond('choice',answer())
self.store.decision_review('choice',review())
health=self.store.queue_health()['decisions']
self.assertEqual(health['pending_count'],1)
self.assertEqual(health['cancelled_count'],1)
def test_legacy_response_migration_never_accepts_or_loses_snapshot(self):
path=Path(self.tmp.name)/'old.sqlite3'
db=sqlite3.connect(path)
db.execute('CREATE TABLE decisions(id TEXT PRIMARY KEY,data TEXT NOT NULL,response TEXT,response_key TEXT)')
original=self.store._normalize_decision(definition())
original.pop('summary');original.pop('supersedes_id')
response=dict(id='legacy-response',option_id='a',comment='Original',created=1,authorization=False)
db.execute('INSERT INTO decisions VALUES(?,?,?,?)',('choice',json.dumps(original),json.dumps(response),'old-key'))
db.commit();db.close()
migrated=Store(path)
current=migrated.decision_get('choice')
self.assertEqual((current['status'],current['revision']),('pending_review',1))
self.assertEqual(current['response']['snapshot']['options'],original['options'])
self.assertIsNone(current['review'])
self.assertEqual(len(Store(path).decision_history('choice')['history']),2)
class WorkflowHTTPTests(unittest.TestCase):
setUp=fixtures.DecisionHTTPTests.setUp
tearDown=fixtures.DecisionHTTPTests.tearDown
request=fixtures.DecisionHTTPTests.request
def test_old_page_submission_without_revision_is_rejected_before_write(self):
self.request('/api/decisions','POST',definition())
old=answer();old.pop('expected_revision')
self.assertEqual(self.request('/api/decisions/choice/respond','POST',old)[0],400)
self.assertIsNone(self.server.store.decision_get('choice')['response'])
self.assertFalse(any(e['kind']=='submission' for e in self.server.store.decision_history('choice')['history']))
first=self.request('/api/decisions/choice/respond','POST',answer())
retry=self.request('/api/decisions/choice/respond','POST',answer())
self.assertEqual(first,retry)
self.assertEqual(first[0],200)
self.assertEqual(sum(e['kind']=='submission' for e in self.server.store.decision_history('choice')['history']),1)
def test_state_reports_current_page_asset_without_changing_decisions(self):
root=Path(self.tmp.name)/'frontend';root.mkdir()
self.server.web_root=root
(root/'index.html').write_text('<script type="module" crossorigin src="/assets/index-first.js"></script>')
self.assertEqual(self.request('/api/state')[1]['frontend_entrypoint'],'/assets/index-first.js')
(root/'index.html').write_text('<script type="module" src="/assets/index-next.js"></script>')
self.assertEqual(self.request('/api/state')[1]['frontend_entrypoint'],'/assets/index-next.js')
(root/'index.html').unlink()
self.assertIsNone(self.request('/api/state')[1]['frontend_entrypoint'])
def test_limited_credential_route_matrix_and_closed_writes(self):
store=self.server.store
store.decision(definition());bind(store)
code,issued=self.request('/api/decisions/choice/consultation-credential','POST',{})
self.assertEqual(code,200)
token=issued['token'];headers={'Authorization':'Bearer '+token}
with store.db() as db:
rows=[dict(r) for r in db.execute('SELECT * FROM decision_credentials')]
self.assertEqual(rows[0]['token_hash'],hashlib.sha256(token.encode()).hexdigest())
self.assertNotIn(token,json.dumps(rows))
for path in ['/api/decisions/choice','/api/decisions/choice/history','/api/decisions/choice/consultation']:
self.assertEqual(self.request(path,headers=headers)[0],200)
for method,path,payload in [('GET','/api/state',None),('GET','/api/decisions/other',None),('GET','/api/decision-bridge-bindings',None),
('POST','/api/decisions/choice/respond',answer()),('POST','/api/decisions/choice/review',review()),
('POST','/api/decisions/choice/complete',completion()),('POST','/api/sessions',{}),
('POST','/api/decisions/choice/consultation',dict(text='x',client_key='x')),
('POST','/api/decisions/choice/consultation-credential',{}),
('POST','/api/decisions/choice/bind-session',{}),('POST','/api/decisions/choice/archive-receipt',{})]:
with self.subTest(path=path): self.assertEqual(self.request(path,method,payload,headers)[0],403)
for field,value in [('task_id','other-task'),('supersedes_id','other'),('requires_authorization',False)]:
self.assertEqual(self.request('/api/decisions/choice','PATCH',dict(expected_revision=1,reason='Out of scope',**{field:value}),headers)[0],403)
self.assertEqual(self.request('/api/decisions/choice','PATCH',dict(expected_revision=1,reason='Evidence',summary='Updated'),headers)[0],200)
self.assertEqual(self.request('/api/decisions/choice/facts','POST',dict(idempotency_key='fact',question='Fact?'),headers)[0],200)
store.decision_respond('choice',answer(expected_revision=2));store.decision_review('choice',review(expected_revision=2));store.decision_complete('choice',completion(expected_revision=2))
self.assertEqual(self.request('/api/decisions/choice','PATCH',dict(expected_revision=2,reason='Late',summary='x'),headers)[0],403)
self.assertEqual(self.request('/api/decisions/choice/facts','POST',dict(idempotency_key='late',question='Late?'),headers)[0],403)
self.assertEqual(self.request('/api/decisions/choice/history',headers=headers)[0],200)
def test_workflow_http_endpoints_and_conflicts(self):
self.request('/api/decisions','POST',definition())
self.assertEqual(self.request('/api/decisions/choice/consultation')[0],409)
bind(self.server.store)
self.assertEqual(self.request('/api/decision-bridge-bindings')[0],200)
self.assertEqual(self.request('/api/decisions/choice/respond','POST',answer())[0],200)
self.assertEqual(self.request('/api/decisions/choice/review','POST',review())[0],200)
self.assertEqual(self.request('/api/decisions/choice/complete','POST',completion())[0],200)
self.assertEqual(self.request('/api/decisions/choice/archive-receipt','POST',dict(thread_id=THREAD,idempotency_key='archive',receipt='tool receipt'))[0],200)
self.assertEqual(self.request('/api/decisions/choice/history')[1]['history'][-1]['kind'],'archive')
if __name__=='__main__': unittest.main()
+18 -9
View File
@@ -18,7 +18,7 @@ def definition(**changes):
def answer(**changes):
value = dict(option_id='a',comment='Keep this exact comment',idempotency_key='key')
value = dict(expected_revision=1,option_id='a',comment='Keep this exact comment',idempotency_key='key')
value.update(changes)
return value
@@ -294,16 +294,17 @@ class DecisionTests(unittest.TestCase):
self.assertEqual(first,self.store.decision(explicit))
with self.assertRaises(Conflict):
self.store.decision(definition(question='Changed'))
self.assertEqual(self.store.decision_notifications()['pending_count'],0)
self.assertEqual(self.store.decision_notifications()['pending_count'],1)
def test_persistence_response_dedup_and_ack(self):
self.store.decision(definition())
self.store.decision_ack({'notification_id':self.store.decision_notifications()['notifications'][0]['notification_id']})
with patch('subprocess.run',side_effect=AssertionError('must not execute')):
first = self.store.decision_respond('choice',answer())
reopened = Store(self.path)
self.assertEqual(first,reopened.decision_respond('choice',answer()))
self.assertEqual(first,reopened.decision(definition()))
self.assertEqual(first['status'],'decided')
self.assertEqual(first['status'],'pending_review')
self.assertFalse(first['response']['authorization'])
self.assertEqual(first['response']['comment'],answer()['comment'])
for changes in [dict(comment='changed'),dict(idempotency_key='other'),dict(option_id=None)]:
@@ -312,7 +313,7 @@ class DecisionTests(unittest.TestCase):
queue = reopened.decision_notifications()
self.assertEqual(queue['pending_count'],1)
notice = queue['notifications'][0]
self.assertEqual(set(notice),{'notification_id','target','decision'})
self.assertEqual(set(notice),{'notification_id','target','decision','event'})
self.assertEqual(notice['target'],'control')
self.assertEqual(notice['decision'],first)
ack = dict(notification_id=notice['notification_id'])
@@ -325,7 +326,7 @@ class DecisionTests(unittest.TestCase):
def test_authorization_is_only_pending_verification(self):
self.store.decision(definition(requires_authorization=True,options=[]))
value = self.store.decision_respond('choice',answer(option_id=None,comment='Approve sudo'))
self.assertEqual(value['status'],'pending_verification')
self.assertEqual(value['status'],'pending_review')
self.assertIs(value['response']['authorization'],False)
def test_invalid_definitions(self):
@@ -342,7 +343,7 @@ class DecisionTests(unittest.TestCase):
def test_invalid_answers_and_ack(self):
self.store.decision(definition())
for changes in [dict(option_id=None),dict(option_id='bad'),dict(comment=None),
for changes in [dict(option_id=None,comment=''),dict(option_id='bad'),dict(comment=None),
dict(comment='x'*8001),dict(idempotency_key=''),dict(authorization=True)]:
with self.subTest(changes=changes):
with self.assertRaises(Invalid): self.store.decision_respond('choice',answer(**changes))
@@ -350,7 +351,7 @@ class DecisionTests(unittest.TestCase):
with self.assertRaises(Invalid): self.store.decision_ack(dict(notification_id='missing'))
with self.assertRaises(Invalid): self.store.decision_ack(dict(notification_id='missing',target='human'))
self.assertEqual(self.store.state()['decisions'][0]['status'],'open')
self.assertEqual(self.store.decision_notifications()['pending_count'],0)
self.assertEqual(self.store.decision_notifications()['pending_count'],1)
self.store.decision(definition(id='free',options=[]))
for option,comment in [(None,' '),('a','text')]:
with self.assertRaises(Invalid):
@@ -358,6 +359,7 @@ class DecisionTests(unittest.TestCase):
def test_concurrent_same_key_has_one_response_and_notification(self):
self.store.decision(definition())
self.store.decision_ack({'notification_id':self.store.decision_notifications()['notifications'][0]['notification_id']})
with concurrent.futures.ThreadPoolExecutor(max_workers=8) as pool:
values = list(pool.map(lambda _:self.store.decision_respond('choice',answer()),range(16)))
self.assertTrue(all(v == values[0] for v in values))
@@ -365,6 +367,7 @@ class DecisionTests(unittest.TestCase):
def test_concurrent_distinct_answers_have_one_winner(self):
self.store.decision(definition())
self.store.decision_ack({'notification_id':self.store.decision_notifications()['notifications'][0]['notification_id']})
def respond(index):
try:
return self.store.decision_respond('choice',answer(idempotency_key=str(index)))
@@ -377,8 +380,9 @@ class DecisionTests(unittest.TestCase):
def test_atomic_rollback_on_outbox_failure(self):
self.store.decision(definition())
self.store.decision_ack({'notification_id':self.store.decision_notifications()['notifications'][0]['notification_id']})
with self.store.db() as db:
db.execute("CREATE TRIGGER fail_notice BEFORE INSERT ON decision_notifications BEGIN SELECT RAISE(ABORT,'synthetic'); END")
db.execute("CREATE TRIGGER fail_notice BEFORE INSERT ON decision_workflow_notifications BEGIN SELECT RAISE(ABORT,'synthetic'); END")
with self.assertRaises(Exception): self.store.decision_respond('choice',answer())
self.assertEqual(self.store.state()['decisions'][0]['status'],'open')
self.assertEqual(self.store.decision_notifications()['pending_count'],0)
@@ -387,6 +391,9 @@ class DecisionTests(unittest.TestCase):
for index in range(103):
did = 'choice-'+str(index)
self.store.decision(definition(id=did))
with self.store.db() as db:
nid=db.execute('SELECT id FROM decision_workflow_notifications ORDER BY seq DESC LIMIT 1').fetchone()[0]
self.store.decision_ack({'notification_id':nid})
self.store.decision_respond(did,answer())
queue = self.store.decision_notifications()
self.assertEqual(queue['pending_count'],103)
@@ -441,6 +448,8 @@ class DecisionHTTPTests(unittest.TestCase):
self.assertEqual(self.request(notifications,headers={'Authorization':''})[0],401)
self.assertEqual(self.request('/api/state')[1]['decisions'],[])
self.assertEqual(self.request(create,'POST',definition())[0],200)
created_notice=self.request(notifications)[1]['notifications'][0]
self.request(ack,'POST',dict(notification_id=created_notice['notification_id']))
self.assertEqual(self.request(create,'POST',definition(question='different'))[0],409)
self.assertEqual(self.request(respond,'POST',answer(option_id='bad'))[0],400)
code,value=self.request(respond,'POST',answer())
@@ -452,7 +461,7 @@ class DecisionHTTPTests(unittest.TestCase):
self.assertEqual(self.request(notifications)[1]['pending_count'],0)
self.assertEqual(self.request(notifications+'?target=human')[0],404)
self.assertEqual(self.request(respond+'?x=1','POST',answer())[0],404)
self.assertEqual(self.request('/api/decisions/choice','PATCH',definition())[0],404)
self.assertEqual(self.request('/api/decisions/choice','PATCH',definition())[0],400)
self.assertEqual(self.request('/api/state')[1]['decisions'][0],value)
def test_cross_site_only_public_top_level_navigation(self):
+68
View File
@@ -0,0 +1,68 @@
"""Transport evidence and demand survive storage reopen without resending."""
import json
import tempfile
import time
import unittest
from pathlib import Path
from agent_control.store import Store
from agent_control.conversation import project
from test_decision_workflow import bind
from test_decisions import definition
class DemandTests(unittest.TestCase):
def setUp(self):
self.tmp=tempfile.TemporaryDirectory()
self.path=Path(self.tmp.name)/'state.sqlite3'
self.store=Store(self.path)
self.store.decision(definition())
bind(self.store)
def tearDown(self):
self.tmp.cleanup()
def demand(self):
return Store(self.path).decision_bindings()['bindings'][0]['demand']
def test_persisted_queue_and_expired_claims_have_distinct_demand(self):
m=self.store.send(dict(session_id='consult',text='Question',idempotency_key='one'))
self.assertEqual(m['delivery_stage'],'queued')
self.assertEqual(self.demand()['queued'],1)
self.assertEqual(self.demand()['human_queued'],1)
self.assertIsNotNone(self.demand()['oldest_queued_at'])
claim=self.store.claim(dict(session_id='consult',worker_id='worker',lease_seconds=10))['message']
self.assertEqual(self.demand()['inflight'],1)
with self.store.db() as db:
db.execute('UPDATE messages SET lease_until=? WHERE id=?',(time.time()-1,m['id']))
self.assertEqual(self.demand()['queued'],1)
with self.store.db() as db:
db.execute('UPDATE messages SET started=1 WHERE id=?',(m['id'],))
self.assertEqual(self.demand()['uncertain'],1)
self.assertEqual(self.demand()['queued'],0)
self.assertEqual(Store(self.path).send(dict(session_id='consult',text='Question',idempotency_key='one'))['id'],m['id'])
self.assertEqual(len(self.store.messages('consult')),1)
def test_safe_projection_uses_host_evidence_not_local_start(self):
m=self.store.send(dict(session_id='consult',text='Question',idempotency_key='one'))
stages=[('claimed',None,None,'queued'),
('claimed',dict(state='submitting'),None,'queued'),
('claimed',dict(state='accepted',receipt_id='private'),None,'delivered'),
('claimed',dict(state='observed',turn_id='private'),None,'processing'),
('uncertain',dict(state='accepted'),None,'blocked'),
('completed',dict(state='observed'),'reply','replied')]
for status,submission,response,expected in stages:
with self.store.db() as db:
db.execute('UPDATE messages SET status=?,started=1,submission=?,response_id=? WHERE id=?',
(status,json.dumps(submission) if submission else None,response,m['id']))
view=Store(self.path).conversation('consult')[0]
self.assertEqual(view['delivery_stage'],expected)
self.assertNotIn('submission',view)
self.assertNotIn('private',json.dumps(view))
def test_mirrored_history_does_not_fabricate_delivery_proof(self):
row=dict(id='history',text='Question',source='human',origin='session_history',status='delivered',created=1)
self.assertNotIn('delivery_stage',project([row],[])[0])
if __name__=='__main__':
unittest.main()
+28
View File
@@ -123,5 +123,33 @@ class MirrorTests(unittest.TestCase):
client.instance='two'
with self.assertRaisesRegex(RuntimeError,'another control'): sync(Server(),client,cfg)
def test_lost_import_ack_retries_same_external_identity_without_model_execution(self):
class Server:
def history(self,tid):
return {'id':tid},[{'id':'turn','status':'completed','items':[
{'id':'reply','type':'agentMessage','phase':'final_answer','text':'result'}]}]
class Client:
calls=[]
imported={}
lose_ack=True
def call(self,path,data=None):
if path.startswith('/api/messages'):return {'messages':[]}
if path=='/api/state':return {'instance_id':'one'}
self.calls.append(data)
for item in data['items']:self.imported[item['id']]=item
if self.lose_ack:
self.lose_ack=False
raise OSError('server persisted import but response was lost')
return {'deferred':[]}
with tempfile.TemporaryDirectory() as root:
cfg={'thread_id':'thread','session_id':'session','control':{},'state_file':str(Path(root)/'worker.json')}
client=Client()
with self.assertRaises(OSError):sync(Server(),client,cfg)
self.assertFalse((Path(root)/'mirror-state.json').exists())
sync(Server(),client,cfg);sync(Server(),client,cfg)
self.assertEqual(len(client.calls),2)
self.assertEqual(client.calls[0],client.calls[1])
self.assertEqual(list(client.imported),['reply'])
if __name__=='__main__':unittest.main()
+148
View File
@@ -10,6 +10,53 @@ import notifier
class NotifierTests(unittest.TestCase):
def test_decisions_prefer_fresh_work_but_waiting_items_survive_restart_and_age(self):
normal={'notification_id':'ordinary','checkpoint':'half','task':{'id':'work'}}
decision={'notification_id':'choice','decision':{'id':'decision'}}
state={}
self.assertEqual(notifier.schedule_notifications([normal,decision],state,100)[0],decision)
# Persist/reload and a continuing stream of fresh decisions cannot starve old work.
state=json.loads(json.dumps(state))
fresh={'notification_id':'new-choice','decision':{'id':'new'}}
self.assertEqual(notifier.schedule_notifications([fresh,normal],state,221)[0],normal)
self.assertEqual(state['notification_waiting']['eta:ordinary'],100)
def test_waiting_age_does_not_bypass_uncertain_target_backpressure(self):
with tempfile.TemporaryDirectory() as root:
cfg,n,path=self.fixture(root);cfg['enforce_backpressure']=True
class Client:
def call(self,p,data=None):return {'notifications':[n]} if p.endswith('notifications') else {}
state={'notification_waiting':{'hook:note1':0}}
with patch.object(notifier,'target_ready',return_value=False),patch.object(notifier.subprocess,'run') as run:
notifier.deliver(Client(),cfg,state,path)
run.assert_not_called()
self.assertEqual(json.loads(path.read_text())['notification_waiting']['hook:note1'],0)
def test_uncertain_reconciliation_rejects_wrong_thread_even_with_exact_input(self):
import hashlib
with tempfile.TemporaryDirectory() as root:
cfg,n,path=self.fixture(root)
prompt=notifier.notification_text(n)
state={'deliveries':{'note1':{'thread_id':cfg['notification_targets']['control'],
'input_sha256':hashlib.sha256(prompt.encode()).hexdigest(),'state':'submitting'}}}
class Client:
acks=[]
def call(self,p,data=None):
if p.endswith('notifications'):return {'notifications':[n]}
self.acks.append(p);return {}
class Reader:
def __init__(self,*args):pass
def __enter__(self):return self
def __exit__(self,*args):pass
def history(self,thread):return {'id':'different-thread'},[{'id':'turn','items':[
{'type':'userMessage','content':[{'type':'text','text':prompt}]}]}]
client=Client()
with patch.object(notifier,'AppServer',Reader),patch.object(notifier.subprocess,'run') as run:
with self.assertRaises(RuntimeError):notifier.deliver(client,cfg,state,path)
run.assert_not_called()
self.assertEqual(client.acks,[])
self.assertEqual(state['deliveries']['note1']['state'],'submitting')
def fixture(self,root):
cfg={'control':{},'notification_targets':{'control':'11111111-1111-4111-8111-111111111111'},'codex':'codex','cwd':root}
n={'notification_id':'note1','target':'control','hook':{'source':'test','event_id':'incident','summary':'synthetic failure','severity':'warning','status':'firing'}}
@@ -157,6 +204,107 @@ class NotifierTests(unittest.TestCase):
self.assertIn(cfg['execution_notification_targets']['worker'],run.call_args.args[0])
self.assertNotIn(cfg['internal_event_thread_id'],run.call_args.args[0])
def test_decision_workflow_uses_bound_consultation_and_never_replays(self):
with tempfile.TemporaryDirectory() as root:
cfg,_,path=self.fixture(root);cfg['decision_notifications']=True
thread='44444444-4444-4444-8444-444444444444'
n={'notification_id':'fact-answer','target':'decision','decision':{'id':'one','title':'Plan','session_thread_id':thread},
'event':{'kind':'fact_answered','request_id':'fact-one','answer':'The prerequisite is verified.'}}
class Client:
def call(self,p,data=None):return {'notifications':[n]} if p=='/api/decision-notifications' else {'notifications':[]}
class Reader:
def __init__(self,*args):pass
def __enter__(self):return self
def __exit__(self,*args):pass
def call(self,method,params):
return {'thread':{'id':thread}} if method=='thread/read' else {'data':[]}
result=SimpleNamespace(returncode=0,stdout='Queued message 22222222-2222-4222-8222-222222222222 for thread '+thread+'.')
state={}
with patch.object(notifier.subprocess,'run',return_value=result) as run,patch.object(notifier,'AppServer',Reader):
notifier.deliver(Client(),cfg,state,path);notifier.deliver(Client(),cfg,state,path)
self.assertEqual(run.call_count,1)
self.assertIn(thread,run.call_args.args[0])
self.assertNotIn(cfg['notification_targets']['control'],run.call_args.args[0])
record=state['deliveries']['decision:fact-answer']
self.assertEqual(record['decision_id'],'one')
self.assertEqual(record['event_kind'],'fact_answered')
def test_fact_answer_completion_reconciles_empty_outbox_without_resend(self):
import hashlib
with tempfile.TemporaryDirectory() as root:
cfg,_,path=self.fixture(root)
thread='44444444-4444-4444-8444-444444444444'
prompt='fact answer exact input'
record={'kind':'decision','decision_id':'one','event_kind':'fact_answered',
'thread_id':thread,'input_sha256':hashlib.sha256(prompt.encode()).hexdigest(),
'state':'accepted','acked':True}
state={'deliveries':{'decision:answer':record}}
class Reader:
body=prompt
identity=thread
def __init__(self,*args):pass
def __enter__(self):return self
def __exit__(self,*args):pass
def call(self,method,params):
if method=='thread/read':return {'thread':{'id':self.identity}}
return {'data':[{'id':'real-turn','status':'completed','completedAt':123,
'items':[{'type':'userMessage','content':[{'type':'text','text':self.body}]},
{'type':'agentMessage','phase':'final_answer','text':'verified'}]}]}
client=SimpleNamespace(call=lambda *args:{'notifications':[]})
with patch.object(notifier,'AppServer',Reader),patch.object(notifier.subprocess,'run') as run:
Reader.body=prompt+' changed'
notifier.deliver(client,cfg,state,path)
self.assertFalse(record.get('processing_done'))
Reader.body=prompt;Reader.identity='wrong-thread'
with self.assertRaises(RuntimeError):notifier.deliver(client,cfg,state,path)
self.assertFalse(record.get('processing_done'))
Reader.identity=thread
notifier.deliver(client,cfg,state,path)
run.assert_not_called()
self.assertEqual(record['turn_id'],'real-turn')
self.assertTrue(json.loads(path.read_text())['deliveries']['decision:answer']['processing_done'])
def test_review_notice_is_concise_and_submission_is_not_acceptance(self):
n={'notification_id':'notice','decision':{'id':'one','title':'Plan','options':[{'id':'a','label':'Private option detail'}]},
'event':{'kind':'reviewed','reason':'Suitable in scope','impact':'No migration needed','execution_plan':'Verify before rollout'}}
text=notifier.notification_text(n)
self.assertNotIn('Private option detail',text)
self.assertIn('#/decisions?decision=one',text)
n['event']={'kind':'submitted','revision':2}
self.assertIn('不要把提交直接当接受',notifier.notification_text(n))
n['event']={'kind':'archive_required','revision':3}
self.assertIn('不能只写数据库冒充宿主归档',notifier.notification_text(n))
def test_failed_decision_submission_marker_does_not_queue_or_leave_unknown_model_input(self):
with tempfile.TemporaryDirectory() as root:
cfg,_,path=self.fixture(root);cfg['decision_notifications']=True
n={'notification_id':'submit','target':'control','decision':{'id':'one','title':'Plan'},'event':{'kind':'submitted','revision':1}}
class Client:
failed=False
def call(self,p,data=None):
if p=='/api/decision-notifications':return {'notifications':[n]}
if p.endswith('/submitting') and not self.failed:
self.failed=True;raise OSError('temporary marker interruption')
return {'notifications':[]}
c=Client();state={}
result=SimpleNamespace(returncode=0,stdout='Queued message 22222222-2222-4222-8222-222222222222 for thread '+cfg['notification_targets']['control']+'.')
with patch.object(notifier.subprocess,'run',return_value=result) as run:
with self.assertRaises(RuntimeError):notifier.deliver(c,cfg,state,path)
self.assertEqual(state['deliveries'],{})
run.assert_not_called()
notifier.deliver(c,cfg,state,path)
self.assertEqual(run.call_count,1)
def test_consultation_target_cannot_point_to_primary_or_unbound_thread(self):
with tempfile.TemporaryDirectory() as root:
cfg,_,path=self.fixture(root);cfg['decision_notifications']=True
n={'notification_id':'bad','target':'decision','decision':{'id':'one','session_thread_id':cfg['notification_targets']['control']},'event':{'kind':'fact_answered'}}
class Client:
def call(self,p,data=None):return {'notifications':[n]} if p=='/api/decision-notifications' else {'notifications':[]}
with patch.object(notifier.subprocess,'run') as run:
with self.assertRaises(RuntimeError):notifier.deliver(Client(),cfg,{},path)
run.assert_not_called()
def test_no_events_means_no_conversation_input(self):
with tempfile.TemporaryDirectory() as root:
cfg,n,path=self.fixture(root)
+4 -2
View File
@@ -42,11 +42,13 @@ class QueueTests(unittest.TestCase):
self.store.task(dict(id='task',name='Task',session_id='worker',
eta_min_minutes=1,eta_max_minutes=2,eta_basis='Measured'))
self.store.decision(dict(id='decision',title='Choose',question='Which approach?'))
for notice in self.store.decision_notifications()['notifications']:
self.store.decision_ack(dict(notification_id=notice['notification_id']))
self.store.eta_tick(70)
with patch('agent_control.store.time.time',return_value=80):
self.store.hook(firing(event_id='recent',severity='critical'))
self.store.hook_ack(dict(notification_id=first['notifications'][0]['notification_id']))
self.store.decision_respond('decision',dict(option_id=None,comment='Selected',idempotency_key='choice'))
self.store.decision_respond('decision',dict(option_id=None,comment='Selected',idempotency_key='choice',expected_revision=1))
self.store.task_report(dict(report_id='receipt',task_id='task',session_id='worker',
stage='progress',current_progress='Verified',summary='Progress',evidence=[]))
health=self.store.queue_health(100)
@@ -101,7 +103,7 @@ class QueueTests(unittest.TestCase):
def test_coalesce_does_not_touch_user_decision_or_message(self):
self.store.session(dict(id='s',name='Synthetic'))
self.store.decision(dict(id='d',title='Choose',question='Which approach?'))
self.store.decision_respond('d',dict(option_id=None,comment='User choice',idempotency_key='choice'))
self.store.decision_respond('d',dict(option_id=None,comment='User choice',idempotency_key='choice',expected_revision=1))
before=self.store.decision_notifications()
self.store.send(dict(session_id='s',text='Real user request',idempotency_key='user-message'))
messages=self.store.messages('s')